Fix widget catalog category pages being empty due to liquidjs regression #11549
+2
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note, this wouldn't have occurred if the deploy respected the pnpm lockfile. I'll prioritize figuring out the deploy actions using pnpm instead of npm for consistency. |
|
Visit the preview URL for this PR (updated for commit 68f98a8): https://flutter-docs-prod--pr11549-fix-widget-catalog-category-orz6muys.web.app |
MaryaBelanger
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression to
breakin the latest liquidjs release caused each category page's contents to not be rendered. This fixes this by instead relying on the built-infindfilter which is simpler and works in versions with and without the behavior change.Fixes #11533
Fixes #11534
Fixes #11535
Fixes #11536
Fixes #11537
Fixes #11538
Fixes #11539
Fixes #11540
Fixes #11541
Fixes #11543
Fixes #11547
Fixes #11548
Fixes #11550
Fixes #11551