-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix and cleanup implicit animations codelab (#9201)
Essentially this PR is focused on improving the clarity of the steps which are diff based, matching starting and ending runnable samples to the steps, removing unnecessary code, and completing some cleanup of the examples and the surrounding text. **Detailed list of changes:** - Sets up code excerpts for the starting and complete example code which were mismatched with the actual steps/instructions. Then updates them to match. - Adds missing type specifiers and simplifies variable declarations. - Adjusts trailing commas and formatting in opacity sample for easier to read diffs. - Removes extra folders/steps that are not currently used. - Adds missing type specifiers and simplifies variable declarations. - Moves away from inline ignores since the diff tooling doesn't remove them, making the diffs more confusing and the line numbers inconsistent between steps. Ignoring in the analysis options file allows for consistent line numbers. - Changes text of button from "change" to "Change" to match instructions. - Fixes a few instructions in the codelab's text. - Removes the embedded survey. - Adds a README to the example directory explaining its setup. Closes #6929
- Loading branch information
Showing
24 changed files
with
169 additions
and
589 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Implicit animations codelab examples | ||
|
||
The code samples within this folder are used | ||
within the [Implicit animations codelab][]. | ||
|
||
- `container1` -> `container5` are used for the | ||
steps of "Shape-shifting effect" portion. | ||
- `container1` is also used for the runnable starter sample and | ||
`container5` for the complete sample. | ||
- `container6` is an extra step that showcases specifying a | ||
non-default animation curve. | ||
- `opacity1` -> `opacity5` are used for the | ||
steps of "Fade-in text effect" portion. | ||
- `opacity1` is also used for the runnable starter sample and | ||
`opacity5` for the complete sample. | ||
- The severity of `missing_required_argument` is ignored manually | ||
in the [`analysis_options.yaml`](analysis_options.yaml) file since the | ||
diffing infrastructure currently can't handle the `ignore` for it. | ||
|
||
[Implicit animations codelab]: https://docs.flutter.dev/codelabs/implicit-animations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.