Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable macosui tests with new hash #244

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Re-enable macosui tests with new hash #244

merged 1 commit into from
Apr 6, 2023

Conversation

eliasyishak
Copy link
Contributor

Re-enabling the macosui tests that were failing per this issue filed in flutter/flutter: flutter/flutter#123669

The PR fixing the issue in customer's repo: macosui/macos_ui#402

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@eliasyishak eliasyishak requested a review from goderbauer April 6, 2023 17:09
goderbauer
goderbauer approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI @GroovinChip

@goderbauer
Copy link
Member

Thank you, @eliasyishak

@auto-submit auto-submit bot merged commit 297e821 into main Apr 6, 2023
@auto-submit auto-submit bot deleted the enable-macosui-tests branch April 6, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
autosubmit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliasyishak @goderbauer