Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker_android] Improved Bitmap resize on Android #6947

Closed
wants to merge 19 commits into from

Conversation

beroso
Copy link
Contributor

@beroso beroso commented Jan 12, 2023

Improves Bitmap load and resize on Android.

Issue: flutter/flutter#118383

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@beroso beroso requested a review from GaryQian as a code owner January 12, 2023 13:00
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Jan 12, 2023

test-exempt: performance improvement

@Hixie
Copy link
Contributor

Hixie commented Jan 12, 2023

(but testing it is even better, actually. @stuartmorgan's suggestion was "to make it possible to inject a mock BitmapFactory into ImageResizer, then test (via native unit tests) that you get the expected calls to it in different cases")

@beroso
Copy link
Contributor Author

beroso commented Jan 17, 2023

I think the tests are OK, thanks for the team support. It's ready for review now.

@reidbaker reidbaker requested review from tarrinneal and stuartmorgan and removed request for GaryQian February 9, 2023 19:27
@beroso beroso changed the title [image_picker] Improved Bitmap resize on Android [image_picker_android] Improved Bitmap resize on Android Feb 21, 2023
@stuartmorgan
Copy link
Contributor

We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.

Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord.

Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants