Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add more CODEOWNERS #5779

Merged
merged 2 commits into from
May 18, 2022
Merged

Add more CODEOWNERS #5779

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
278317b
Add more CODEOWNERS
stuartmorgan May 17, 2022
71c7249
Add local_auth Windows
stuartmorgan May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,17 @@
# reviewed by someone else.

# Plugin-level rules.
packages/camera/** @bparrishMines
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bparrishMines I gave you camera since you have previous experience there; let me know if that works for you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me!

packages/file_selector/** @stuartmorgan
packages/google_maps_flutter/** @stuartmorgan
packages/google_sign_in/** @stuartmorgan
packages/image_picker/** @stuartmorgan
packages/local_auth/** @stuartmorgan
packages/path_provider/** @gaaclarke
packages/plugin_platform_interface/** @stuartmorgan
packages/quick_actions/** @stuartmorgan
packages/shared_preferences/** @gaaclarke
packages/url_launcher/** @stuartmorgan
packages/video_player/** @gaaclarke
packages/webview_flutter/** @bparrishMines

Expand Down Expand Up @@ -42,3 +51,23 @@ packages/shared_preferences/shared_preferences_ios/** @cyanglaz
packages/url_launcher/url_launcher_ios/** @jmagman
packages/video_player/video_player_avfoundation/** @hellohuanlin
packages/webview_flutter/webview_flutter_wkwebview/** @cyanglaz

# - Linux
Copy link
Contributor Author

@stuartmorgan stuartmorgan May 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbracken I gave you all of the desktop plugins with the idea that you'll delegate ownership over time; if you have any you want to delegate now, let me know.

(I also expect that in practice I'll still be a primary reviewer for a lot of desktop implementations, but I figured that putting you instead of me will remind me that we're supposed to be working on handing those off incrementally 🙂 )

packages/path_provider/path_provider_linux/** @cbracken
packages/shared_preferences/shared_preferences_linux/** @cbracken
packages/url_launcher/url_launcher_linux/** @cbracken

# - macOS
packages/file_selector/file_selector_macos/** @cbracken
packages/path_provider/path_provider_macos/** @cbracken
packages/shared_preferences/shared_preferences_macos/** @cbracken
packages/url_launcher/url_launcher_macos/** @cbracken

# - Windows
packages/camera/camera_windows/** @cbracken
packages/file_selector/file_selector_windows/** @cbracken
packages/image_picker/image_picker_windows/** @cbracken
packages/local_auth/local_auth_windows/** @cbracken
packages/path_provider/path_provider_windows/** @cbracken
packages/shared_preferences/shared_preferences_windows/** @cbracken
packages/url_launcher/url_launcher_windows/** @cbracken