-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview_flutter] local html and baseUrl support #2830
Conversation
baseUrl: "file://"+path+"/"
Any reason this is not merged yet? |
I really need this feature, what happened? |
Thanks for the contribution! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog. Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are a primary way we’re prioritizing non-trivial reviews, so we encourage you to file an issue and associate it with this PR. |
@mvanbeusekom This PR is relevant to recent discussion about alternate loading options. We'll need to evaluate everything (URL-based, string-based, local file-based) holistically to ensure we don't end up with a mess of paramaters that are all mutually exclusive, and then factor that into API iteration here. |
Description
This is an enhancement of the current implementation of flutter webview. This addresses the issue of loading static html in webview, alongwith baseUrl support. This works in both ios and android.
Related Issues
Earlier we used to do it through initialUrl, by converting it to base64 string and so on. React native has a proper support for static html and baseUrl.(fluttercommunity/flutter_webview_plugin#23)
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?