Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] local html and baseUrl support #2830

Closed
wants to merge 20 commits into from

Conversation

uc-apa
Copy link

@uc-apa uc-apa commented Jun 16, 2020

Description

This is an enhancement of the current implementation of flutter webview. This addresses the issue of loading static html in webview, alongwith baseUrl support. This works in both ios and android.

Related Issues

Earlier we used to do it through initialUrl, by converting it to base64 string and so on. React native has a proper support for static html and baseUrl.(fluttercommunity/flutter_webview_plugin#23)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@uc-apa uc-apa requested a review from amirh as a code owner June 16, 2020 13:31
@cyanglaz cyanglaz changed the title local html and baseUrl support [webview_flutter] local html and baseUrl support Jul 15, 2020
@AhmedNourJamalElDin
Copy link

Any reason this is not merged yet?

@TheManuz
Copy link

I really need this feature, what happened?

@stuartmorgan
Copy link
Contributor

Thanks for the contribution! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are a primary way we’re prioritizing non-trivial reviews, so we encourage you to file an issue and associate it with this PR.

@stuartmorgan
Copy link
Contributor

@mvanbeusekom This PR is relevant to recent discussion about alternate loading options. We'll need to evaluate everything (URL-based, string-based, local file-based) holistically to ensure we don't end up with a mess of paramaters that are all mutually exclusive, and then factor that into API iteration here.

@stuartmorgan stuartmorgan removed the request for review from amirh July 13, 2021 15:36
@stuartmorgan
Copy link
Contributor

Closing as obsolete, since #4446, #4486, and to-be-written-soon follow-up PRs add local file handling based on discussion about how we want the suite of load APIs to interact. Thanks again for the submission though!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants