Skip to content

[go_router_builder]: Add support for relative routes #9749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LukasMirbt
Copy link

Adds support for TypedRelativeGoRoute.

Builds on #9732

Continuation of #8476 by @ThangVuNguyenViet

Compared to #8476, the approach taken in this PR avoids breaking changes and creates a separate RouteData subclass instead of extending GoRouteData. The approach increases flexibility and avoids extending behavior that might not make sense for a relative route.

Fully resolves flutter/flutter#108177.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for relative routes with TypedRelativeGoRoute. I've added one suggestion to improve validation by ensuring that paths for relative routes are not absolute, which will help catch errors early during development.

@LukasMirbt LukasMirbt force-pushed the go-router-builder/add-support-for-relative-routes branch 9 times, most recently from 2162d41 to 2f641f3 Compare August 6, 2025 23:39
@LukasMirbt
Copy link
Author

LukasMirbt commented Aug 7, 2025

Update

  • Factored out repeated logic between GoRouteConfig and RelativeGoRouteConfig with a mixin
  • Added readme section
  • Added build-time validation preventing the entire sub-tree of a TypedRelativeGoRoute from containing a TypedGoRoute (all other types are valid)
  • Added build-time validation preventing a TypedRelativeGoRoute path from starting with "/"

@LukasMirbt LukasMirbt force-pushed the go-router-builder/add-support-for-relative-routes branch 3 times, most recently from a2592d6 to 31d0358 Compare August 7, 2025 21:59
children: <Widget>[
ElevatedButton(
onPressed: () {
const DetailsRoute(detailId: 'DetailsId').goRelative(context);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it may be useful to provide a way to access a detail route of a certain go route from a complete different go route?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that could be a nice additional feature but I consider it out of scope for this PR.

@override
String get factorConstructorParameters => 'factory: $_mixinName._fromState,';
String get location => RelativeGoRouteData.\$location($_locationArgs,$_locationQueryParams);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this still have a location?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having access to the value without ./ (e.g. person/p1 compared to ./person/p1) is useful in some situations. However, it might be confusing for it to be called "location". I renamed it to "subpath" instead.

@LukasMirbt LukasMirbt force-pushed the go-router-builder/add-support-for-relative-routes branch 2 times, most recently from 0cd3be6 to db007f4 Compare August 7, 2025 23:14
@LukasMirbt
Copy link
Author

Update

  • Added to readme explaining the purpose of relative routes
  • Bumped minor version
  • Renamed confusingly named RelativeGoRouteData location getter to subpath

@LukasMirbt LukasMirbt requested a review from chunhtai August 7, 2025 23:27
@LukasMirbt LukasMirbt force-pushed the go-router-builder/add-support-for-relative-routes branch from db007f4 to ce05058 Compare August 8, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[go_router] Add support for relative routes
2 participants