-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[go_router_builder]: Add support for relative routes #9749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[go_router_builder]: Add support for relative routes #9749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for relative routes with TypedRelativeGoRoute
. I've added one suggestion to improve validation by ensuring that paths for relative routes are not absolute, which will help catch errors early during development.
2162d41
to
2f641f3
Compare
Update
|
a2592d6
to
31d0358
Compare
children: <Widget>[ | ||
ElevatedButton( | ||
onPressed: () { | ||
const DetailsRoute(detailId: 'DetailsId').goRelative(context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it may be useful to provide a way to access a detail route of a certain go route from a complete different go route?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that could be a nice additional feature but I consider it out of scope for this PR.
@override | ||
String get factorConstructorParameters => 'factory: $_mixinName._fromState,'; | ||
String get location => RelativeGoRouteData.\$location($_locationArgs,$_locationQueryParams); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this still have a location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having access to the value without ./
(e.g. person/p1
compared to ./person/p1
) is useful in some situations. However, it might be confusing for it to be called "location". I renamed it to "subpath" instead.
0cd3be6
to
db007f4
Compare
Update
|
db007f4
to
ce05058
Compare
Adds support for TypedRelativeGoRoute.
Builds on #9732
Continuation of #8476 by @ThangVuNguyenViet
Compared to #8476, the approach taken in this PR avoids breaking changes and creates a separate RouteData subclass instead of extending GoRouteData. The approach increases flexibility and avoids extending behavior that might not make sense for a relative route.
Fully resolves flutter/flutter#108177.
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assist
bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3