Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autosubmit label to dependabot PRs #8101

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 15, 2024

The flutter/flutter and flutter/engine repo put the autosubmit label on dependabot PRs so if all checks pass then no review is necessary and it will merge. For example, flutter/flutter#156024 merged without any human intervention.

In packages this is rarer (due to CHANGELOG and version bumps), but still happens, for example #8097 bumps a testImplementation dependency and passed all checks.

Add autosubmit to the packages repo for dependabot PRs so if all checks pass they just merge. If checks don't pass, the bot will remove the label and we'll be back to manual review required.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman marked this pull request as ready for review November 15, 2024 17:31
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2024
@auto-submit auto-submit bot merged commit a076bae into flutter:main Nov 18, 2024
77 checks passed
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2024
sinyu1012 added a commit to sinyu1012/packages that referenced this pull request Nov 19, 2024
* main:
  [ci] Take screenshot when native drive test is taking longer than 10 minutes (flutter#8050)
  Applied Gradle Plugins Declaratively for Most Remaining Plugin Example Apps (Part 3) (flutter#8037)
  [pigeon]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 2.0.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter#7867)
  [gradle]: Bump androidx.test.ext:junit-ktx from 1.1.5 to 1.2.1 in /packages/shared_preferences/shared_preferences_android/android (flutter#8097)
  [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.20 to 2.0.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter#7869)
  [gradle]: Bump org.hamcrest:hamcrest from 2.2 to 3.0 in /packages/espresso/android (flutter#8092)
  [pigeon]: Bump io.mockk:mockk from 1.13.12 to 1.13.13 in /packages/pigeon/platform_tests/test_plugin/android (flutter#7868)
  [shared_pref]: Bump io.mockk:mockk from 1.13.12 to 1.13.13 in /packages/shared_preferences/shared_preferences_android/android (flutter#7866)
  Add autosubmit label to dependabot PRs (flutter#8101)
  Roll Flutter from 0e2d55e0e7b2 to b3818f6b5979 (23 revisions) (flutter#8118)
  [gradle]: Bump org.mockito.kotlin:mockito-kotlin from 4.1.0 to 5.4.0 in /packages/interactive_media_ads/android (flutter#8095)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 19, 2024
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 19, 2024
flutter/packages@c1eabf5...fc4adc7

2024-11-18 magder@google.com [ci] Take screenshot when native drive test
is taking longer than 10 minutes (flutter/packages#8050)
2024-11-18 jessiewong401@gmail.com Applied Gradle Plugins Declaratively
for Most Remaining Plugin Example Apps (Part 3) (flutter/packages#8037)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 2.0.21 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7867)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump androidx.test.ext:junit-ktx from 1.1.5 to 1.2.1 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#8097)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.20 to 2.0.21 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7869)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump org.hamcrest:hamcrest from 2.2 to 3.0 in /packages/espresso/android
(flutter/packages#8092)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump io.mockk:mockk from 1.13.12 to 1.13.13 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7868)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com
[shared_pref]: Bump io.mockk:mockk from 1.13.12 to 1.13.13 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#7866)
2024-11-18 magder@google.com Add autosubmit label to dependabot PRs
(flutter/packages#8101)
2024-11-18 engine-flutter-autoroll@skia.org Roll Flutter from
0e2d55e to b3818f6 (23 revisions) (flutter/packages#8118)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jmagman jmagman deleted the dependabot-autosubmit branch December 20, 2024 04:30
@jmagman
Copy link
Member Author

jmagman commented Dec 20, 2024

#8306 merged without human intervention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants