[google_maps_flutter_platform_interface] Split CameraUpdate into derived classes to use structured data
#7596
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
… into derived classes to use structured data (flutter/packages#7596)
flutter/packages@b4e0fc1...bb53e5d 2024-09-09 magder@google.com [ci] Increase deprecation check minimum to macOS 14 (flutter/packages#7544) 2024-09-09 paulberry@google.com [camerax] Ignore new `unreachable_switch_default` warning. (flutter/packages#7592) 2024-09-09 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_platform_interface] Split `CameraUpdate` into derived classes to use structured data (flutter/packages#7596) 2024-09-09 stuartmorgan@google.com [google_maps_flutter] Disable setAndGetScrollPosition on iOS (flutter/packages#7609) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
| /// The amount of padding by which the view is inset. | ||
| final double padding; | ||
| @override | ||
| Object toJson() => <Object>['newLatLngZoom', bounds.toJson(), padding]; |
There was a problem hiding this comment.
@yaakovschectman, @stuartmorgan
This should have been 'newLatLngBounds' instead of 'newLatLngZoom'
There was a problem hiding this comment.
Thanks for flagging that; I've retracted 2.9.1 on pub.dev. I assumed we already had Dart unit testing of the JSON we sent, since we usually do, but apparently not in this case.
@yaakovschectman You'll need to fix this so we can publish a new non-retracted version of the platform interface to unblock your other PR.
There was a problem hiding this comment.
I've added you both as reviewers to a PR that addresses this fix.
There was a problem hiding this comment.
Why can't I find the new version (2.9.1) of the google_maps_flutter package in pub.dev ?
There was a problem hiding this comment.
@dhiaCodes The updated package is google_maps_flutter_platform_interface, a dependency of google_maps_flutter.
…atLngBounds.toJson (#7626) Replace `newLatLngZoom` with `newLatLngBounds` as it should be. See #7596 (review) Part of flutter/flutter#152928 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [ ] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
Platform interface part of #7507
flutter/flutter#152928
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.