Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigeon] adds support for collections of enums and classes #7476

Merged

Conversation

tarrinneal
Copy link
Contributor

@tarrinneal tarrinneal commented Aug 22, 2024

adds support for collections of enums and classes
fixes flutter/flutter#133728

@tarrinneal tarrinneal force-pushed the custom-codecs-5-enum-strikes-back branch from bc675fa to cedfc5c Compare August 27, 2024 00:59
@tarrinneal tarrinneal changed the title custom-codecs-5-enum-strikes-back [pigeon] adds support for collections of enums and classes Aug 27, 2024
@tarrinneal tarrinneal marked this pull request as ready for review August 27, 2024 01:17
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/pigeon/CHANGELOG.md Outdated Show resolved Hide resolved
packages/pigeon/lib/swift_generator.dart Outdated Show resolved Hide resolved
@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2024
@auto-submit auto-submit bot merged commit b835465 into flutter:main Aug 30, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 3, 2024
flutter/packages@c9c0004...848d7e9

2024-08-30 mhvdijk@gmail.com [flutter_adaptive_scaffold] Compare breakpoints (flutter/packages#7531)
2024-08-30 tarrinneal@gmail.com [pigeon] adds support for collections of enums and classes (flutter/packages#7476)
2024-08-30 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes bug where ad can replay during content playback (flutter/packages#7537)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pigeon] Add support for collections of enums
3 participants