[in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products #7473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouiseHsu
changed the title
| @@ -41,6 +41,9 @@ public class InAppPurchasePlugin: NSObject, FlutterPlugin, InAppPurchaseAPI { | |||
| registrar.addMethodCallDelegate(instance, channel: channel) | |||
| registrar.addApplicationDelegate(instance) | |||
| SetUpInAppPurchaseAPI(messenger, instance) | |||
| if #available(iOS 15.0, *) { | |||
| InAppPurchase2APISetup.setUp(binaryMessenger: messenger, api: instance) | |||
There was a problem hiding this comment.
InAppPurchaseStoreKit2APISetup
| let products = try await Product.products(for: identifiers) | ||
| let productMessages = products.map { product in | ||
| product.convertToPigeon() | ||
| } |
There was a problem hiding this comment.
products.map { $0.convertToPigeon() }
|
|
||
| @available(iOS 15.0, macOS 12.0, *) | ||
| extension Product { | ||
| func convertToPigeon() -> SK2ProductMessage { |
There was a problem hiding this comment.
var pigeonMessage: SK2ProductMessage {
return ...
}
|
|
||
| @available(iOS 15.0, macOS 12.0, *) | ||
| extension Product.ProductType { | ||
| func convertToPigeon() -> SK2ProductTypeMessage { |
...pp_purchase/in_app_purchase_storekit/example/ios/RunnerTests/InAppPurchase2PluginTests.swift
Outdated
Show resolved
Hide resolved
...pp_purchase/in_app_purchase_storekit/example/ios/RunnerTests/InAppPurchase2PluginTests.swift
Outdated
Show resolved
Hide resolved
| @@ -17,6 +18,9 @@ const String kPurchaseErrorCode = 'purchase_error'; | |||
| /// Indicates store front is Apple AppStore. | |||
| const String kIAPSource = 'app_store'; | |||
|
|
|||
| /// Experimental flag for StoreKit2. | |||
| bool _useStoreKit2 = false; | |||
There was a problem hiding this comment.
move inside the class
| @@ -5,6 +5,7 @@ | |||
| import 'package:in_app_purchase_platform_interface/in_app_purchase_platform_interface.dart'; | |||
|
|
|||
| import '../../store_kit_wrappers.dart'; | |||
| import '../store_kit_2_wrappers/sk2_product_wrapper.dart'; | |||
|
|
|||
| /// The class represents the information of a product as registered in the Apple | |||
| /// AppStore. | |||
There was a problem hiding this comment.
can you update comments
hellohuanlin
approved these changes
Aug 28, 2024
...in_app_purchase/in_app_purchase_storekit/darwin/Classes/StoreKit2/StoreKit2Translators.swift
Show resolved
Hide resolved
LouiseHsu
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2024
…Payments and products (flutter/packages#7473)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 30, 2024
flutter/packages@2a0f254...c9c0004 2024-08-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Kotlin implementation for ProxyApis (flutter/packages#6371) 2024-08-29 louisehsu@google.com [in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products (flutter/packages#7473) 2024-08-29 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add correct material spacing and panes (flutter/packages#7428) 2024-08-29 34871572+gmackall@users.noreply.github.com [many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) (flutter/packages#7521) 2024-08-29 tarrinneal@gmail.com [pigeon] allow gen of unused classes (flutter/packages#7529) 2024-08-29 magder@google.com Increase deprecation check minimum to iOS 14 and macOS 13 (flutter/packages#7431) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vasilich6107
pushed a commit
to artflutter/flutter
that referenced
this pull request
Aug 30, 2024
flutter/packages@2a0f254...c9c0004 2024-08-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Kotlin implementation for ProxyApis (flutter/packages#6371) 2024-08-29 louisehsu@google.com [in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products (flutter/packages#7473) 2024-08-29 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add correct material spacing and panes (flutter/packages#7428) 2024-08-29 34871572+gmackall@users.noreply.github.com [many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) (flutter/packages#7521) 2024-08-29 tarrinneal@gmail.com [pigeon] allow gen of unused classes (flutter/packages#7529) 2024-08-29 magder@google.com Increase deprecation check minimum to iOS 14 and macOS 13 (flutter/packages#7431) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@2a0f254...c9c0004 2024-08-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Kotlin implementation for ProxyApis (flutter/packages#6371) 2024-08-29 louisehsu@google.com [in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products (flutter/packages#7473) 2024-08-29 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add correct material spacing and panes (flutter/packages#7428) 2024-08-29 34871572+gmackall@users.noreply.github.com [many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) (flutter/packages#7521) 2024-08-29 tarrinneal@gmail.com [pigeon] allow gen of unused classes (flutter/packages#7529) 2024-08-29 magder@google.com Increase deprecation check minimum to iOS 14 and macOS 13 (flutter/packages#7431) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains support for StoreKit2's canMakePayments and products.
This also contains basic scaffolding for SK2 support, such as pigeon translators.
Part of flutter/flutter#116383
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).