-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift #7171
Merged
LouiseHsu
merged 8 commits into
flutter:main
from
LouiseHsu:iap-tests-paymentqueueDelete
Jul 18, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
43a60a5
init
LouiseHsu 0f08af5
symlinks
LouiseHsu 80b6596
Merge branch 'main' into iap-tests-paymentqueueDelete
LouiseHsu dbcfc3d
update availability
LouiseHsu 7defccb
Merge branch 'iap-tests-paymentqueueDelete' of github.com:LouiseHsu/p…
LouiseHsu 93b83cf
rename tests
LouiseHsu 082cb01
versioning
LouiseHsu 656df10
.
LouiseHsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
## 0.3.17+2 | ||
|
||
* Converts FIAPPaymentQueueDeleteTests to swift. | ||
|
||
## 0.3.17+1 | ||
|
||
* Converts main plugin tests to swift. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
...p_purchase/in_app_purchase_storekit/example/ios/RunnerTests/FIAPPaymentQueueDeleteTests.m
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
...rchase/in_app_purchase_storekit/example/ios/RunnerTests/FIAPPaymentQueueDeleteTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../shared/RunnerTests/FIAPPaymentQueueDeleteTests.swift |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
...purchase/in_app_purchase_storekit/example/macos/RunnerTests/FIAPPaymentQueueDeleteTests.m
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
...hase/in_app_purchase_storekit/example/macos/RunnerTests/FIAPPaymentQueueDeleteTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../shared/RunnerTests/FIAPPaymentQueueDeleteTests.swift |
134 changes: 0 additions & 134 deletions
134
...urchase/in_app_purchase_storekit/example/shared/RunnerTests/FIAPPaymentQueueDeleteTests.m
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should've always been here. When mac support first got added i think this got missed here
For some reason the objc macos tests still ran fine even though it was using FIAPPaymentQueueDelegate which was technically unavailable, but when i rewrote the tests in swift, the compiler complained.
Adding this should be fine as its a wrapper over SKPaymentQueueDelegate and mac is supported