Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interactive_media_ads] Add SPM support #6756

Merged
merged 4 commits into from
May 21, 2024
Merged

[interactive_media_ads] Add SPM support #6756

merged 4 commits into from
May 21, 2024

Conversation

stuartmorgan
Copy link
Contributor

Restructures the placeholder iOS implementation to follow the Swift Package Manager layout, and enables SPM support.

Also marks the plugin as unpublished since it's not ready for incremental changes to be published yet.

Fixes flutter/flutter#146906

Pre-launch Checklist

@stuartmorgan
[interactive_media_ads] Add SPM support
1073c2b 
Restructures the placeholder iOS implementation to follow the Swift
Package Manager layout, and enables SPM support.

Also marks the plugin as unpublished since it's not ready for
incremental changes to be published yet.

Fixes flutter/flutter#146906
@stuartmorgan stuartmorgan requested a review from vashworth May 17, 2024 17:11
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan
Copy link
Contributor Author

test-exempt: configuration change

(SPM support itself is tested automatically by CI just by being enabled.)

vashworth
vashworth reviewed May 17, 2024
View reviewed changes
packages/interactive_media_ads/ios/interactive_media_ads.podspec
@@ -25,5 +25,5 @@ Downloaded by pub (not CocoaPods).
'LD_RUNPATH_SEARCH_PATHS' => '/usr/lib/swift',
}
s.swift_version = '5.0'
s.resource_bundles = {'interactive_media_ads_privacy' => ['Resources/PrivacyInfo.xcprivacy']}
s.resource_bundles = {'interactive_media_ads_privacy' => ['interactive_media_ads/Sources/interactive_media_ads/Resources/PrivacyInfo.xcprivacy']}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to move the PrivacyInfo.xcprivacy out of the Resources folder to make it inline with the create templates?

FYI I just updated the instructions to reflect that: flutter/flutter#146256 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong feelings for our own plugins; the layout is pretty much arbitrary. The main reason to move it in the template was to make it easy to have a single commented-out line that's specific to the privacy manifest, which doesn't matter in our actual plugins.

bparrishMines
bparrishMines reviewed May 20, 2024
View reviewed changes
packages/interactive_media_ads/pubspec.yaml Outdated
@@ -3,6 +3,7 @@ description: A Flutter plugin for using the Interactive Media Ads SDKs on Androi
repository: https://github.com/flutter/packages/tree/main/packages/interactive_media_ads
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+interactive_media_ads%22
version: 0.0.1
publish_to: none
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to set this to none?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you had intended to set it to none after the initial publish, until it was actually ready. If not, we can remove this and do incremental releases for everything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is pre-1.0, I think it's fine to have incremental releases. We also plan to release the Android implementation early for feedback.

vashworth
vashworth approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll defer to you and @bparrishMines on the publishing intentions

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2024
@auto-submit auto-submit bot merged commit ef756da into flutter:main May 21, 2024
74 checks passed
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@stuartmorgan @TecHaxter
[interactive_media_ads] Add SPM support (flutter#6756)
d84b5a9 
Restructures the placeholder iOS implementation to follow the Swift Package Manager layout, and enables SPM support.

Also marks the plugin as unpublished since it's not ready for incremental changes to be published yet.

Fixes flutter/flutter#146906
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2024
@engine-flutter-autoroll
ef756da [interactive_media_ads] Add SPM support (flutter/packages#6756)
43d2689
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 22, 2024
@engine-flutter-autoroll
Roll Packages from ba19b24 to 6525441 (12 revisions) (#148864)
8f227fe 
flutter/packages@ba19b24...6525441

2024-05-22 stuartmorgan@google.com [local_auth] Convert native unit tests to Swift (flutter/packages#6779)
2024-05-22 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump androidx.annotation:annotation from 1.5.0 to 1.8.0 in /packages/interactive_media_ads/android (flutter/packages#6771)
2024-05-22 vongrejadam@gmail.com [in_app_purchase_android] Introduced new ReplacementMode for Android's billing client (flutter/packages#6515)
2024-05-21 hashirshoaeb@gmail.com [go_router] New feature improve debug full path (flutter/packages#6714)
2024-05-21 stuartmorgan@google.com [interactive_media_ads] Add SPM support (flutter/packages#6756)
2024-05-21 engine-flutter-autoroll@skia.org Roll Flutter from 02a6c91 to d02292d (22 revisions) (flutter/packages#6778)
2024-05-21 stuartmorgan@google.com [local_auth] Remove use of OCMock (flutter/packages#6757)
2024-05-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.3 to 3.25.6 (flutter/packages#6777)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/file_selector/file_selector_android/android (flutter/packages#6769)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#6765)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6762)
2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter from adf279f to 02a6c91 (8 revisions) (flutter/packages#6776)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@engine-flutter-autoroll @victorsanni
Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter#148864)
8959014 
flutter/packages@ba19b24...6525441

2024-05-22 stuartmorgan@google.com [local_auth] Convert native unit tests to Swift (flutter/packages#6779)
2024-05-22 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump androidx.annotation:annotation from 1.5.0 to 1.8.0 in /packages/interactive_media_ads/android (flutter/packages#6771)
2024-05-22 vongrejadam@gmail.com [in_app_purchase_android] Introduced new ReplacementMode for Android's billing client (flutter/packages#6515)
2024-05-21 hashirshoaeb@gmail.com [go_router] New feature improve debug full path (flutter/packages#6714)
2024-05-21 stuartmorgan@google.com [interactive_media_ads] Add SPM support (flutter/packages#6756)
2024-05-21 engine-flutter-autoroll@skia.org Roll Flutter from 02a6c91 to d02292d (22 revisions) (flutter/packages#6778)
2024-05-21 stuartmorgan@google.com [local_auth] Remove use of OCMock (flutter/packages#6757)
2024-05-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.3 to 3.25.6 (flutter/packages#6777)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/file_selector/file_selector_android/android (flutter/packages#6769)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#6765)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6762)
2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter from adf279f to 02a6c91 (8 revisions) (flutter/packages#6776)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@stuartmorgan @arc-yong
[interactive_media_ads] Add SPM support (flutter#6756)
1384d06 
Restructures the placeholder iOS implementation to follow the Swift Package Manager layout, and enables SPM support.

Also marks the plugin as unpublished since it's not ready for incremental changes to be published yet.

Fixes flutter/flutter#146906
@reidbaker reidbaker mentioned this pull request Jul 2, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparrishMines bparrishMines bparrishMines left review comments

@vashworth vashworth vashworth approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[interactive_media_ads] Add Swift Package Manager compatibility to interactive_media_ads
3 participants
@stuartmorgan @bparrishMines @vashworth