[file_selector_ios, image_picker_ios] Remove Swift Package Support #6740
Conversation
|
Do we have any idea yet why we don't see this in CI? We can land this as is, but it would be nice to have a test that we can ensure we'd don't regress later when re-landing support. |
| @@ -1,3 +1,7 @@ | |||
| ## 0.5.2+1 | |||
|
|
|||
| * Removes Swift Package Manager compatibility. | |||
There was a problem hiding this comment.
How about "Temporarily remove Swift Package Manager compatibility to resolve issues with Cocoapods builds."?
So far, seems to be older versions of Xcode are having this issue and we don't enforce Xcode 15 yet. I'll add an issue to reland this and when they do, to temporarily test with Xcode 14 |
|
Have we actually validated that it's an Xcode 14 vs 15 thing? I thought that was still speculative based on the issue discussion (i.e., nobody seems to have indicated confirming that the same project works in 15 but not 14). |
I confirmed Xcode 14 breaks: https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_x64%20ios_build_all_packages%20master/484/overview |
vashworth
added
the
autosubmit
|
I think we can get rid of the manual modulemaps, that was a lot of work to |
Unfortunately, we're not the only ones that do this, though. I've seen other plugin authors copy our model to achieve the same. I would think we would want to provide a way for them to maintain it, but yeah the modulemaps are super annoying and I wish we could get rid of them. I'll think on it more. |
|
Have we considered cherry picking an Xcode 15 requirement to 3.22? |
We could, but this issue isn't the only problem we're having with the double modulemaps. @loic-sharma also ran into an issue when trying to convert So I think we need to figure out a better way to handle modulemaps |
flutter/packages@87a02e3...ae4dd32 2024-05-17 engine-flutter-autoroll@skia.org Roll Flutter from 0d22d91 to 00425ef (14 revisions) (flutter/packages#6753) 2024-05-16 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Add test for `onExit` (flutter/packages#6614) 2024-05-16 32666446+hamdikahloun@users.noreply.github.com [camera_android_camerax] update to latest stable camerax 1.3.3 (flutter/packages#6737) 2024-05-16 magder@google.com [camera_avfoundation] Revert camera example PRODUCT_BUNDLE_IDENTIFIER (flutter/packages#6735) 2024-05-16 15619084+vashworth@users.noreply.github.com [file_selector_ios, image_picker_ios] Remove Swift Package Support (flutter/packages#6740) 2024-05-16 katelovett@google.com [two_dimensional_scrollables] TreeView (flutter/packages#6592) 2024-05-16 engine-flutter-autoroll@skia.org Roll Flutter from 39651e8 to 0d22d91 (23 revisions) (flutter/packages#6748) 2024-05-16 byoungchan.lee@gmx.com [pigeon][swift] Removes FlutterError in favor of PigeonError (flutter/packages#6611) 2024-05-16 15619084+vashworth@users.noreply.github.com [webview_flutter] Skip "Video playback policy" drive tests (flutter/packages#6747) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#6740) Plugins converted to Swift Package Manager that use a modulemap seem to be having issues with there being a `module.modulemap`. As a temporary solution to unblock people, we'll remove the `module.modulemap` and Swift Package support (`Package.swift`). Temporary solution for flutter/flutter#148307.
…lutter#6740) Plugins converted to Swift Package Manager that use a modulemap seem to be having issues with there being a `module.modulemap`. As a temporary solution to unblock people, we'll remove the `module.modulemap` and Swift Package support (`Package.swift`). Temporary solution for flutter/flutter#148307.
Plugins converted to Swift Package Manager that use a modulemap seem to be having issues with there being a
module.modulemap. As a temporary solution to unblock people, we'll remove themodule.modulemapand Swift Package support (Package.swift).Temporary solution for flutter/flutter#148307.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.