-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[path_provider] Add Swift Package Manager support #6680
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
test-exempt: configuration change (SPM support is automatically tested by CI now that it's enabled.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@5ccddfc...8de142d 2024-05-07 stuartmorgan@google.com [path_provider] Add Swift Package Manager support (flutter/packages#6680) 2024-05-07 goderbauer@google.com [go_router] guard context access in then clauses (flutter/packages#6685) 2024-05-07 engine-flutter-autoroll@skia.org Roll Flutter from 04424e1 to 7920a52 (27 revisions) (flutter/packages#6683) 2024-05-07 srawlins@google.com [camera] Ignore implementation imports outside of lib (flutter/packages#6191) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Adds SPM support for iOS and macOS. No Xcode project changes are included, to maintain compatibility with `stable`. Fixes flutter/flutter#146913
Adds SPM support for iOS and macOS. No Xcode project changes are included, to maintain compatibility with `stable`. Fixes flutter/flutter#146913
Adds SPM support for iOS and macOS.
No Xcode project changes are included, to maintain compatibility with
stable
.Fixes flutter/flutter#146913
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).