Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[most on Android] Bump compile SDK version to 34 #5783

Merged
merged 15 commits into from
Jan 22, 2024
Merged

[most on Android] Bump compile SDK version to 34 #5783

merged 15 commits into from
Jan 22, 2024

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jan 2, 2024 •
edited
Loading

This PR does the following:

  1. Bumps compile SDK version to 34 for all packages on Android besides webview_flutter_android, which is blocked by finishing [Android] Run all flutter/packages Android tests on devices running Android 34 flutter#137082.
  2. Bumps legacy all_packages app to 33 because compiling failed after completing 1 (see example of failing build here). There was a Flutter fix available, so I believe this bump is safe.
  3. Replaces all deprecated compileSdkVersion usages with compileSdk.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@camsim99 camsim99 mentioned this pull request Jan 8, 2024
Closed
@camsim99 camsim99 added the override: no versioning needed Override the check requiring version bumps for most changes label Jan 22, 2024
Piinks
Piinks approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

goderbauer
goderbauer approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added override: no changelog needed Override the check requiring CHANGELOG updates for most changes autosubmit Merge PR when tree becomes green via auto submit App labels Jan 22, 2024
@auto-submit auto-submit bot merged commit 88b7d16 into flutter:main Jan 22, 2024
80 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2024
@engine-flutter-autoroll
88b7d16 [most on Android] Bump compile SDK version to 34 (flutter/pac…
bc0dda7 
…kages#5783)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 23, 2024
@engine-flutter-autoroll
Roll Packages from e4cbf23 to 841fe90 (7 revisions) (#142047)
2b6c2ee 
flutter/packages@e4cbf23...841fe90

2024-01-22 katelovett@google.com [two_dimensional_scrollables] Fix TableSpanDecoration rects when axes are reversed (flutter/packages#5916)
2024-01-22 43054281+camsim99@users.noreply.github.com [most on Android] Bump compile SDK version to 34 (flutter/packages#5783)
2024-01-22 dshukertjr@gmail.com [url_launcher]: Fix a grammar error in the comments of launchUrl method (flutter/packages#5919)
2024-01-22 10687576+bparrishMines@users.noreply.github.com [webview_platform_interface] Adds WebResourceRequest to HttpResponseError (flutter/packages#5790)
2024-01-22 43054281+camsim99@users.noreply.github.com [camerax] Update `Activity` references when `ActivityAware` lifecycle methods called (flutter/packages#5784)
2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter from 5dea6b9 to 3ee8ff2 (9 revisions) (flutter/packages#5955)
2024-01-22 stuartmorgan@google.com [espresso] Replace deprecated `getObservatoryUri` (flutter/packages#5788)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
@huycozy huycozy mentioned this pull request Mar 21, 2024
Closed
@bartekpacia
Copy link
Member

bartekpacia commented Apr 3, 2024 •
edited
Loading

Hi @camsim99, when will the updates be released?

I'm specifically interested in path_provider_android and flutter_plugin_android_lifecycle having compileSdk 34.

@stuartmorgan
Copy link
Contributor

We don't generally do releases for compileSdk changes. What's the use case where the compileSdk is affecting you?

@bartekpacia
Copy link
Member

Please see flutter/flutter#63533 (comment)

@stuartmorgan
Copy link
Contributor

Please see flutter/flutter#63533 (comment)

Interesting. @reidbaker @camsim99 It sounds like we should revisit the version bump exemption for compileSdk changes.

@reidbaker
Copy link
Contributor

Yeah I maintain that there isnt a large impact but we wouldnt want a long time to pass without a published version being shipped.

@stuartmorgan
Copy link
Contributor

I'll update the wiki to remove that then; the carve-out is only supposed to be for things with no client benefit (for exactly that reason, we used to have things clients actually wanted sitting unpublished for a long time.

@bartekpacia
Copy link
Member

Thanks a lot. This change will reduce my CI build times.

@stuartmorgan
Copy link
Contributor

@bartekpacia The policy change will affect future changes like this one; for 34 specifically please feel free to send a PR that bumps the version of anything here that hasn't already been incidentally released by later changes to the plugin.

@bartekpacia bartekpacia mentioned this pull request Apr 8, 2024
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Apr 9, 2024
@bartekpacia
Release compileSdk changes (#6491)
17f55d3 
*List which issues are fixed by this PR. You must list at least one issue.*

Release some compileSdk changes made in #5783

See also #5783 (comment)

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@bartekpacia @TecHaxter
Release compileSdk changes (flutter#6491)
ea7fdde 
*List which issues are fixed by this PR. You must list at least one issue.*

Release some compileSdk changes made in flutter#5783

See also flutter#5783 (comment)

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@camsim99 @arc-yong
[most on Android] Bump compile SDK version to 34 (flutter#5783)
c4cf5ba 
This PR does the following:

1. Bumps compile SDK version to 34 for all packages on Android besides `webview_flutter_android`, which is blocked by finishing flutter/flutter#137082.
2. Bumps legacy all_packages app to 33 because compiling failed after completing 1 (see example of failing build [here](https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_build_all_packages%20master/5159/overview)). There was a Flutter fix available, so I believe this bump is safe.
3. Replaces all deprecated `compileSdkVersion` usages with `compileSdk`.
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@bartekpacia @arc-yong
Release compileSdk changes (flutter#6491)
9407b3c 
*List which issues are fixed by this PR. You must list at least one issue.*

Release some compileSdk changes made in flutter#5783

See also flutter#5783 (comment)

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@goderbauer goderbauer goderbauer approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

@Piinks Piinks Piinks approved these changes

@gmackall gmackall gmackall approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

@stuartmorgan stuartmorgan Awaiting requested review from stuartmorgan stuartmorgan is a code owner

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@chunhtai chunhtai Awaiting requested review from chunhtai chunhtai is a code owner

@domesticmouse domesticmouse Awaiting requested review from domesticmouse domesticmouse is a code owner

@ditman ditman Awaiting requested review from ditman ditman is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: animations p: camera p: dynamic_layouts The dynamic_layouts package p: espresso p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_adaptive_scaffold p: flutter_image p: flutter_markdown p: flutter_plugin_android_lifecycle p: go_router p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: local_auth p: palette_generator p: path_provider p: pigeon p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@camsim99 @stuartmorgan @bartekpacia @reidbaker @goderbauer @gspencergoog @Piinks @gmackall