Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xdg_directories] added full example in xdg_directories #4385

Closed
wants to merge 7 commits into from

Conversation

AdamMusa
Copy link

@AdamMusa AdamMusa commented Jul 6, 2023

This package does not have an example to show people how to use it so I created a complete project with all methods available on this package .
Here is the screenshot of project

example

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@stuartmorgan
Copy link
Contributor

Thanks for the contribution!

[x] All existing and new tests are passing.

A significant number of CI tests are failing, including the new widget test, so I'm assuming this is still a work in progress. I'll set this to Draft accordingly; please mark as ready for review once the issues are resolved.

@stuartmorgan stuartmorgan marked this pull request as draft July 6, 2023 22:50
@AdamMusa AdamMusa force-pushed the example branch 2 times, most recently from f8017d3 to 2877762 Compare July 13, 2023 07:04
@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Jul 14, 2023
@stuartmorgan
Copy link
Contributor

stuartmorgan commented Aug 17, 2023

Closing as obsolete; another PR to add this example has now landed (#4554).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants