[tool] Use new pub cache location for publish #3962

stuartmorgan · 2023-05-11T00:31:13Z

As of Dart 3.0 (Flutter 3.10), the location that the tool was using for the pub cache wasn't being read, breaking autopublish in CI. This updates to the new location, and adds tests for it.

Should fix the fact that the release step hangs on every package change now.

As of Dart 3.0 (Flutter 3.10), the location that the tool was using for the pub cache wasn't being read, breaking autopublish in CI.

tarrinneal · 2023-05-11T06:09:37Z

script/tool/lib/src/publish_command.dart

    throw ToolExit(1);
  }

-  return p.join(cacheDir, 'credentials.json');
-}();
+  return path.join(configDir, 'pub-credentials.json');


nit: You've changed p -> path in multiple places, but the import is still as p.

That's actually correct; path is a p.Context instance (from our base command class) constructed based on the platform instance, which means it follows the mock platform if one is injected by tests.

What makes this extra confusing I think is that the path package provides everything as both methods on a context, and free functions (which call the method of the same name on the default context). So calling the free functions with a prefixed import and calling the methods on an instance look the same, even though they are actually calling different things.

stuartmorgan · 2023-05-11T10:11:32Z

Landing on red to (hopefully) avoid continued tree breakage.

Pins to a specific version of Flutter, rather than using a branch, to avoid issue like flutter#3962 being surprise out-of-band failures.

Pins to a specific version of Flutter, rather than using a branch, to avoid issue like #3962 being surprise out-of-band failures. This does not change current behavior, as `stable` currently points to the same commit as `3.10.0`.

…es#3962)

flutter/packages@6328cfb...6608b60 2023-05-15 stuartmorgan@google.com [ci] Remove unnecessary Linux libraries (flutter/packages#3975) 2023-05-15 stuartmorgan@google.com [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979) 2023-05-15 stuartmorgan@google.com [ci] Disable Windows repo tool tests (flutter/packages#3980) 2023-05-12 stuartmorgan@google.com [ci] Add LUCI repo tool tests (flutter/packages#3964) 2023-05-12 reidbaker@google.com [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973) 2023-05-12 reidbaker@google.com Update build.gradle with a comment explaining version (flutter/packages#3972) 2023-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958) 2023-05-12 stuartmorgan@google.com [image_picker] Fix Android lints (flutter/packages#3887) 2023-05-12 stuartmorgan@google.com [various] Update minimum Flutter version to 3.3 (flutter/packages#3967) 2023-05-12 stuartmorgan@google.com [tool] Target specific Android unit tests (flutter/packages#3955) 2023-05-12 34871572+gmackall@users.noreply.github.com [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960) 2023-05-12 stuartmorgan@google.com [local_auth] Improve iOS test DI (flutter/packages#3959) 2023-05-12 stuartmorgan@google.com [ci] Ensure scripts fail if a command fails (flutter/packages#3963) 2023-05-11 stuartmorgan@google.com [ci] Pin the Flutter version for `release` (flutter/packages#3965) 2023-05-11 tarrinneal@gmail.com [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784) 2023-05-11 stuartmorgan@google.com [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969) 2023-05-11 stuartmorgan@google.com [tool] Ensure that publish credential path is available (flutter/packages#3970) 2023-05-11 63286031+ahmednfwela@users.noreply.github.com [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877) 2023-05-11 stuartmorgan@google.com [tool] Use new pub cache location for publish (flutter/packages#3962) 2023-05-10 engine-flutter-autoroll@skia.org Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961) 2023-05-10 andrelvsousa@gmail.com [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423) 2023-05-10 43054281+camsim99@users.noreply.github.com [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

As of Dart 3.0 (Flutter 3.10), the location that the tool was using for the pub cache wasn't being read, breaking autopublish in CI. This updates to the new location, and adds tests for it. Should fix the fact that the `release` step hangs on every package change now.

Pins to a specific version of Flutter, rather than using a branch, to avoid issue like flutter#3962 being surprise out-of-band failures. This does not change current behavior, as `stable` currently points to the same commit as `3.10.0`.

[tool] Use new pub cache location for publish

702523c

As of Dart 3.0 (Flutter 3.10), the location that the tool was using for the pub cache wasn't being read, breaking autopublish in CI.

stuartmorgan requested review from ditman, bparrishMines and tarrinneal May 11, 2023 00:31

Merge branch 'main' into tool-update-pub-credential-location

05dcb02

tarrinneal approved these changes May 11, 2023

View reviewed changes

stuartmorgan merged commit 5b7d732 into flutter:main May 11, 2023

stuartmorgan deleted the tool-update-pub-credential-location branch May 11, 2023 10:11

stuartmorgan added a commit to stuartmorgan/packages that referenced this pull request May 11, 2023

[ci] Pin the Flutter version for release

b4258d5

Pins to a specific version of Flutter, rather than using a branch, to avoid issue like flutter#3962 being surprise out-of-band failures.

stuartmorgan mentioned this pull request May 11, 2023

[ci] Pin the Flutter version for release #3965

Merged

reidbaker mentioned this pull request May 12, 2023

[url_launcher] Set broadcast reciever visability as required by target api 34 #3973

Merged

11 tasks

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 8febbba0c387 (21 revisions) flutter/flutter#126832

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

5b7d732 [tool] Use new pub cache location for publish (flutter/packag…

e3a1ec2

…es#3962)

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 8febbba0c387 (21 revisions) flutter/flutter#126859

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

5b7d732 [tool] Use new pub cache location for publish (flutter/packag…

5455406

…es#3962)

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 6608b604b0e7 (22 revisions) flutter/flutter#126865

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

5b7d732 [tool] Use new pub cache location for publish (flutter/packag…

699e4f1

…es#3962)

This was referenced Jul 7, 2023

[Tool] New tool to download android dependencies #4408

Merged

[camera] tree fix format 2023 05 12 #4450

Closed

[tooling] mark infra steps as infra steps in yaml files #4473

Merged

reidbaker mentioned this pull request Jul 26, 2023

[Tooling] Add google owned cache for dependencies as an option in ci #4567

Merged

11 tasks

reidbaker mentioned this pull request Aug 4, 2023

[All] Expand artifact hub to all plugins #4645

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tool] Use new pub cache location for publish #3962

[tool] Use new pub cache location for publish #3962

stuartmorgan commented May 11, 2023 •

edited

Loading

tarrinneal May 11, 2023

stuartmorgan May 11, 2023 •

edited

Loading

stuartmorgan commented May 11, 2023

[tool] Use new pub cache location for publish #3962

[tool] Use new pub cache location for publish #3962

Conversation

stuartmorgan commented May 11, 2023 • edited Loading

tarrinneal May 11, 2023

Choose a reason for hiding this comment

stuartmorgan May 11, 2023 • edited Loading

Choose a reason for hiding this comment

stuartmorgan commented May 11, 2023

stuartmorgan commented May 11, 2023 •

edited

Loading

stuartmorgan May 11, 2023 •

edited

Loading