Skip to content

Commit

Permalink
Disable presubmit: false targets for recipes CQ (#5735)
Browse files Browse the repository at this point in the history
These targets are not enabled in presubmit, but enabled in CQ. This caused latest changes not surfaced from CQ side: CQ runs are based on out dated try runs. For example: `Mac_arm64 ios_platform_tests_shard_1 stable` is using the old build executed on 12/13: https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20ios_platform_tests_shard_1%20stable

This PR disables CQ for targets that are with `presubmit: false`, to unblock recipes CL: https://flutter-review.googlesource.com/c/recipes/+/53301
  • Loading branch information
keyonghan authored Dec 21, 2023
1 parent 6660212 commit 2939417
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1130,7 +1130,6 @@ targets:
timeout: 60
properties:
channel: stable
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: macos_platform_tests.yaml
env_variables: >-
Expand Down Expand Up @@ -1275,7 +1274,6 @@ targets:
timeout: 60
properties:
channel: stable
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 0 --shardCount 5"
Expand All @@ -1291,7 +1289,6 @@ targets:
timeout: 60
properties:
channel: stable
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 1 --shardCount 5"
Expand All @@ -1307,7 +1304,6 @@ targets:
timeout: 60
properties:
channel: stable
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 2 --shardCount 5"
Expand All @@ -1323,7 +1319,6 @@ targets:
timeout: 60
properties:
channel: stable
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 3 --shardCount 5"
Expand All @@ -1339,7 +1334,6 @@ targets:
timeout: 60
properties:
channel: stable
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: ios_platform_tests.yaml
package_sharding: "--shardIndex 4 --shardCount 5"
Expand Down

0 comments on commit 2939417

Please sign in to comment.