Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate MaterialApp in api example test #154550

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix duplicate MaterialApp in api example test #154550

merged 1 commit into from
Sep 4, 2024

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Sep 3, 2024

This PR fixes two tests that created a nested MaterialApp (and it simplifies another test).

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Sep 3, 2024
piedcipher
piedcipher approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@piedcipher piedcipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2024
@auto-submit auto-submit bot merged commit dce20c9 into flutter:master Sep 4, 2024
30 checks passed
@bleroux bleroux deleted the fix_duplicate_material_app_in_api_example_test branch September 4, 2024 06:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dce20c97d Fix duplicate MaterialApp in api example test (flutter/flut…
c19cfee 
…ter#154550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dce20c97d Fix duplicate MaterialApp in api example test (flutter/flut…
a0a7973 
…ter#154550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dce20c97d Fix duplicate MaterialApp in api example test (flutter/flut…
07baba0 
…ter#154550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dce20c97d Fix duplicate MaterialApp in api example test (flutter/flut…
851e88a 
…ter#154550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dce20c97d Fix duplicate MaterialApp in api example test (flutter/flut…
61f1636 
…ter#154550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dce20c97d Fix duplicate MaterialApp in api example test (flutter/flut…
6accd37 
…ter#154550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
dce20c97d Fix duplicate MaterialApp in api example test (flutter/flut…
b327d3e 
…ter#154550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
dce20c97d Fix duplicate MaterialApp in api example test (flutter/flut…
3898a7c 
…ter#154550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
dce20c97d Fix duplicate MaterialApp in api example test (flutter/flut…
1e0f5ed 
…ter#154550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
dce20c97d Fix duplicate MaterialApp in api example test (flutter/flut…
2b9786f 
…ter#154550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
dce20c97d Fix duplicate MaterialApp in api example test (flutter/flut…
992e580 
…ter#154550)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piedcipher piedcipher piedcipher approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bleroux @piedcipher