Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Documentation for ResizeImage Dimensions and Usage #154212

Merged
merged 10 commits into from
Sep 3, 2024
Merged

Improve Documentation for ResizeImage Dimensions and Usage #154212

merged 10 commits into from
Sep 3, 2024

Conversation

RamonFarizel
Copy link
Contributor

@RamonFarizel RamonFarizel commented Aug 27, 2024 •
edited by piedcipher
Loading

This pull request enhances the documentation for the ResizeImage widget to provide clearer guidance on the use of the width and height parameters.

Fixes #136508

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 27, 2024
RamonFarizel and others added 3 commits August 28, 2024 18:32
@RamonFarizel @navaronbracke
Update packages/flutter/lib/src/painting/image_provider.dart
0d8ad50 
Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
@RamonFarizel @navaronbracke
Update packages/flutter/lib/src/painting/image_provider.dart
3d76d08 
Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
@RamonFarizel @navaronbracke
Update packages/flutter/lib/src/painting/image_provider.dart
bf98545 
Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
@goderbauer goderbauer requested review from nate-thegrate and removed request for navaronbracke August 28, 2024 22:11
nate-thegrate
nate-thegrate reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@nate-thegrate nate-thegrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I sort of crammed a bunch of feedback into this tiny addition, so take a look when you have a chance :)

packages/flutter/lib/src/painting/image_provider.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/painting/image_provider.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/painting/image_provider.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/painting/image_provider.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/painting/image_provider.dart Outdated Show resolved Hide resolved
nate-thegrate
nate-thegrate approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@nate-thegrate nate-thegrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with optional whitespace nit)

Thanks for making the improvement here!

packages/flutter/lib/src/painting/image_provider.dart Outdated Show resolved Hide resolved
@RamonFarizel @nate-thegrate
Update packages/flutter/lib/src/painting/image_provider.dart
cd83c89 
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
@RamonFarizel
Copy link
Contributor Author

Thank you all for your support! It was nice to learn a bit more about all those details.

@RamonFarizel @nate-thegrate
Update packages/flutter/lib/src/painting/image_provider.dart
d857db6 
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
goderbauer
goderbauer approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2024
@auto-submit auto-submit bot merged commit 7eb07c9 into flutter:master Sep 3, 2024
69 checks passed
@RamonFarizel RamonFarizel deleted the rf/resize-image-docs branch September 4, 2024 12:58
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7eb07c983 Improve Documentation for ResizeImage Dimensions and Usage (f…
c8b4b7a 
…lutter/flutter#154212)
@nate-thegrate nate-thegrate mentioned this pull request Sep 4, 2024
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7eb07c983 Improve Documentation for ResizeImage Dimensions and Usage (f…
3d1745d 
…lutter/flutter#154212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7eb07c983 Improve Documentation for ResizeImage Dimensions and Usage (f…
c593e74 
…lutter/flutter#154212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7eb07c983 Improve Documentation for ResizeImage Dimensions and Usage (f…
a327a21 
…lutter/flutter#154212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7eb07c983 Improve Documentation for ResizeImage Dimensions and Usage (f…
1343487 
…lutter/flutter#154212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7eb07c983 Improve Documentation for ResizeImage Dimensions and Usage (f…
a5ec542 
…lutter/flutter#154212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
7eb07c983 Improve Documentation for ResizeImage Dimensions and Usage (f…
03c0c41 
…lutter/flutter#154212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
7eb07c983 Improve Documentation for ResizeImage Dimensions and Usage (f…
d7f31c8 
…lutter/flutter#154212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
7eb07c983 Improve Documentation for ResizeImage Dimensions and Usage (f…
5c59429 
…lutter/flutter#154212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
7eb07c983 Improve Documentation for ResizeImage Dimensions and Usage (f…
88d1a7d 
…lutter/flutter#154212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
7eb07c983 Improve Documentation for ResizeImage Dimensions and Usage (f…
b1f21bc 
…lutter/flutter#154212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-thegrate nate-thegrate nate-thegrate approved these changes

@navaronbracke navaronbracke navaronbracke left review comments

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
4 participants
@RamonFarizel @goderbauer @nate-thegrate @navaronbracke