Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test of an Android platform view that draws a gradient #153878

Merged
merged 8 commits into from
Aug 23, 2024
Merged

Add a test of an Android platform view that draws a gradient #153878

merged 8 commits into from
Aug 23, 2024

Conversation

matanlurey
Copy link
Contributor

Closes #152376.

The gradient, for posterity, looks like this:

Let's see if CI agrees!

/cc @johnmccutchan

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 21, 2024
jonahwilliams
jonahwilliams approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

...ver_test/android/app/src/main/kotlin/com/example/android_driver_test/GradientPlatformView.kt Outdated
@@ -0,0 +1,56 @@
package com.example.android_driver_test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License header?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@johnmccutchan
Copy link
Contributor

Woo hoo 🎉

@matanlurey matanlurey mentioned this pull request Aug 21, 2024
Closed
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2024
@auto-submit auto-submit bot merged commit 5e19438 into flutter:master Aug 23, 2024
139 checks passed
@matanlurey matanlurey deleted the android-driver-blue-rectangle branch August 23, 2024 18:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
784b9d0 
flutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
42e4c83 
flutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
8b37533 
flutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 25, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
f3c3525 
flutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
2c1108a 
flutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
5aec40a 
flutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
19983d7 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
a82fb9e 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
33f79d8 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
5006f6a 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
4c98948 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
0195d63 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
d9899ab 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
1364649 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
908c221 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
ba687a4 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
c551410 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
38de66e 
flutter/flutter#153878)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@matanlurey @Buchimi
Add a test of an Android platform view that draws a gradient (flutter…
1b4df3b 
…#153878)

Closes flutter#152376.

The gradient, for posterity, looks like this:

<img src="https://github.com/user-attachments/assets/bed9599a-4e16-499c-af79-b51980095e89" width="150">

Let's see if CI agrees!

/cc @johnmccutchan
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
f4b3bbb 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
24f0588 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
1d7e021 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
9f1bcc8 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
7b6e86c 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
2b7045c 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
96cafc6 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
b30b630 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
0b8634e 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
2ea6d02 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
5921ca3 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
ff76acc 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
b2534ed 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
690f79a 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
6740359 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
3164e99 
flutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
5e194383a Add a test of an Android platform view that draws a gradient (
45efbf1 
flutter/flutter#153878)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

At least 1 on-device UI test of an Android platform view working on CI
3 participants
@matanlurey @johnmccutchan @jonahwilliams