Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write unit tests for API Examples of checkbox.0, checkbox.1 #144888

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Write unit tests for API Examples of checkbox.0, checkbox.1 #144888

merged 8 commits into from
Mar 12, 2024

Conversation

Moelfarri
Copy link
Contributor

Write unit tests for API Examples of checkbox.0, checkbox.1

Part of #130459

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@google-cla Google CLA
Copy link

google-cla bot commented Mar 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Mar 9, 2024
Moelfarri and others added 3 commits March 12, 2024 13:28
@Moelfarri @goderbauer
Update examples/api/test/material/checkbox/checkbox.1_test.dart
a34f2e5 
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
@Moelfarri @goderbauer
Update examples/api/test/material/checkbox/checkbox.1_test.dart
a0c5606 
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
@Moelfarri
fixes indentation and spacing
d2498b7
goderbauer
goderbauer approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer requested a review from gspencergoog March 12, 2024 16:24
gspencergoog
gspencergoog approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks!

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2024
@auto-submit auto-submit bot merged commit 46cb2d7 into flutter:master Mar 12, 2024
132 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
46cb2d7 Write unit tests for API Examples of checkbox.0, checkbox.1 (f…
13fa91b 
…lutter/flutter#144888)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
46cb2d7 Write unit tests for API Examples of checkbox.0, checkbox.1 (f…
0f2a28b 
…lutter/flutter#144888)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
46cb2d7 Write unit tests for API Examples of checkbox.0, checkbox.1 (f…
ad14a02 
…lutter/flutter#144888)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
46cb2d7 Write unit tests for API Examples of checkbox.0, checkbox.1 (f…
858fd28 
…lutter/flutter#144888)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
46cb2d7 Write unit tests for API Examples of checkbox.0, checkbox.1 (f…
7491a5c 
…lutter/flutter#144888)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
46cb2d7 Write unit tests for API Examples of checkbox.0, checkbox.1 (f…
cb54651 
…lutter/flutter#144888)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
46cb2d7 Write unit tests for API Examples of checkbox.0, checkbox.1 (f…
ddf7338 
…lutter/flutter#144888)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
46cb2d7 Write unit tests for API Examples of checkbox.0, checkbox.1 (f…
2865b45 
…lutter/flutter#144888)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
46cb2d7 Write unit tests for API Examples of checkbox.0, checkbox.1 (f…
0c89384 
…lutter/flutter#144888)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
Manual roll Flutter from 61812ca to 394269f (6 revisions) (#6320)
1601b4b 
Manual roll requested by tarrinneal@google.com

flutter/flutter@61812ca...394269f

2024-03-12 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 6cefbe183546 to 67713071563e (5 revisions) (flutter/flutter#145002)
2024-03-12 goderbauer@google.com add missing `await`s (flutter/flutter#144978)
2024-03-12 Moelfarri@gmail.com Write unit tests for API Examples of checkbox.0, checkbox.1 (flutter/flutter#144888)
2024-03-12 goderbauer@google.com Fix typing to unblock pub roll (flutter/flutter#144968)
2024-03-12 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 6745955bb49e to 6cefbe183546 (6 revisions) (flutter/flutter#144996)
2024-03-12 engine-flutter-autoroll@skia.org Roll Packages from d489d84 to d1aeb26 (3 revisions) (flutter/flutter#144994)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
46cb2d7 Write unit tests for API Examples of checkbox.0, checkbox.1 (f…
e9fe1f2 
…lutter/flutter#144888)
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Manual roll Flutter from 61812ca to 394269f (6 revisions) (flutter#6320)
952062d 
Manual roll requested by tarrinneal@google.com

flutter/flutter@61812ca...394269f

2024-03-12 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 6cefbe183546 to 67713071563e (5 revisions) (flutter/flutter#145002)
2024-03-12 goderbauer@google.com add missing `await`s (flutter/flutter#144978)
2024-03-12 Moelfarri@gmail.com Write unit tests for API Examples of checkbox.0, checkbox.1 (flutter/flutter#144888)
2024-03-12 goderbauer@google.com Fix typing to unblock pub roll (flutter/flutter#144968)
2024-03-12 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 6745955bb49e to 6cefbe183546 (6 revisions) (flutter/flutter#144996)
2024-03-12 engine-flutter-autoroll@skia.org Roll Packages from d489d84 to d1aeb26 (3 revisions) (flutter/flutter#144994)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moelfarri @goderbauer @gspencergoog