Add unit tests for AndroidWorkflow.runLicenseManager() #14260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests for #14249. |
cbracken
force-pushed
the
tests-for-version-check
branch
4 times, most recently
from
bc142a5
to
93b1556
Compare
tvolkert
approved these changes
Jan 25, 2018
| when(sdk.sdkManagerPath).thenReturn('/foo/bar/sdkmanager'); | ||
| when(processManager.canRun('/foo/bar/sdkmanager')).thenReturn(false); | ||
|
|
||
| expect(() async => await AndroidWorkflow.runLicenseManager(), throwsToolExit()); |
There was a problem hiding this comment.
I think this can just be:
expect(AndroidWorkflow.runLicenseManager(), throwsToolExit());
Same in the tests above.
There was a problem hiding this comment.
Good call! Done for the two that throw.
cbracken
force-pushed
the
tests-for-version-check
branch
6 times, most recently
from
bfbacd3
to
d7c1bec
Compare
Adds unit tests for AndroidWorkflow.runLicenseManager().
cbracken
force-pushed
the
tests-for-version-check
branch
from
d7c1bec
to
7bce252
Compare
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Adds unit tests for AndroidWorkflow.runLicenseManager().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for AndroidWorkflow.runLicenseManager().