Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove self from CODEOWNERS #125337

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Remove self from CODEOWNERS #125337

merged 1 commit into from
Apr 21, 2023

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 21, 2023 •
edited
Loading

Remove self from CODEOWNERS file for flutter_tools. Now that we have the PR cocoon labeler the tools team should see any PRs that change these files, and tag the right people to review.

Also remove ownership of the CODEOWNERS file itself.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Apr 21, 2023
christopherfujino
christopherfujino approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2023
@auto-submit auto-submit bot merged commit a2c2471 into flutter:master Apr 21, 2023
@jmagman jmagman deleted the codeowner branch April 21, 2023 22:34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
ff0baf8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
aaebaeb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
8467cf2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
bb10a03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
6ac7a52
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
4a12074
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
f3bc038
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
8f06dd2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
5aad042
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
f7ad1ee
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
51ff1e1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
95bccf8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
74943ab
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
a2c2471 Remove self from CODEOWNERS (flutter/flutter#125337)
c089eba
@jmagman jmagman mentioned this pull request Dec 13, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Dec 14, 2023
@jmagman
Add self back to CODEOWNERS (#140080)
b33b872 
I'm back from leave.  Revert #125337 but don't take back the `CODEOWNERS` file itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmagman @christopherfujino