Adds vscode workspace with impeller test runner #55291

gaaclarke · 2024-09-18T22:58:42Z

This PR removes our checked in .vscode files and instead starts a vscode workspace for the engine. As a first step I've added build tasks for the arm64 impeller_unittests. I also setup C++ TestMate so that we can easily navigate to tests and execute them. The tests will be rebuilt before each execution.

The goal would be that eventually all of our c++ tests can be listed here. This is going to make external contribution much easier and make it so I don't have to keep editing the "launch.json" file to run specific tests.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-09-18T22:58:46Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

…re with linux

…bug test ui =(

jtmcdole · 2024-09-19T13:43:47Z

engine.code-workspace

+  ],
+  "settings": {
+    "files.associations": {
+      "optional": "cpp",


shouldn't these be *.<extension> - or are these just loose files lying about the tree. These look like identifiers rather than files.

These are the c++ standard library. Like #include <atomic>. Since there is no extension I think it may have issues figuring out what language it is. I've had this set forever so I decided to share it.

gaaclarke · 2024-09-19T20:00:28Z

Hmm I've looked at this a couple of different ways. It really seems the license checker is failing to pick up the excluded file.

gaaclarke · 2024-09-19T22:39:41Z

This is not going to scale well once we start adding more entries for all our test runners. For that I've written a tool that can deduplicate json files while keeping //engine.code-workspace the source of truth: #55309

jtmcdole

LGTM; i'm assuming Matan is OK with the extensions moving to the workspace.

gaaclarke · 2024-09-20T19:58:37Z

I think I've come up with a better way of reducing redundancy with the workspace. Yaml already has the ability to deduplicate this stuff and can be compiled down to json and json can be compiled back to yaml if we ever accidentally edit the workspace.

…gine#55291)

…155524) flutter/engine@0155f8f...c11e75b 2024-09-23 skia-flutter-autoroll@skia.org Roll Skia from 8c44a27b32a8 to ec0ed4afabf4 (1 revision) (flutter/engine#55351) 2024-09-22 skia-flutter-autoroll@skia.org Roll Skia from 1d03ec881675 to 8c44a27b32a8 (1 revision) (flutter/engine#55342) 2024-09-22 skia-flutter-autoroll@skia.org Roll Skia from c01f89da7c38 to 1d03ec881675 (1 revision) (flutter/engine#55336) 2024-09-21 skia-flutter-autoroll@skia.org Roll Skia from 1be7027570a0 to c01f89da7c38 (1 revision) (flutter/engine#55328) 2024-09-21 skia-flutter-autoroll@skia.org Roll Skia from ca5731228de9 to 1be7027570a0 (1 revision) (flutter/engine#55327) 2024-09-21 skia-flutter-autoroll@skia.org Roll Skia from bdbbdee1db8c to ca5731228de9 (1 revision) (flutter/engine#55326) 2024-09-20 30870216+gaaclarke@users.noreply.github.com Adds vscode workspace with impeller test runner (flutter/engine#55291) 2024-09-20 skia-flutter-autoroll@skia.org Roll Skia from 16f53694ec96 to bdbbdee1db8c (1 revision) (flutter/engine#55321) 2024-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 21402561f6d3 to 419aef963b5a (1 revision) (flutter/engine#55320) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

In #55291 we added a vscode workspace to help with running tests and sharing settings. However, VSCode does not support a config format that has the ability to reduce redundancy and it will get quite unwieldy as we add in all of the engines test runners. To combat that I've added instead a YAML config that can converted to JSON for VSCode. This also adds 2 more test runners: display_list_unittests and impeller_golden_tests [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…lutter#155524) flutter/engine@0155f8f...c11e75b 2024-09-23 skia-flutter-autoroll@skia.org Roll Skia from 8c44a27b32a8 to ec0ed4afabf4 (1 revision) (flutter/engine#55351) 2024-09-22 skia-flutter-autoroll@skia.org Roll Skia from 1d03ec881675 to 8c44a27b32a8 (1 revision) (flutter/engine#55342) 2024-09-22 skia-flutter-autoroll@skia.org Roll Skia from c01f89da7c38 to 1d03ec881675 (1 revision) (flutter/engine#55336) 2024-09-21 skia-flutter-autoroll@skia.org Roll Skia from 1be7027570a0 to c01f89da7c38 (1 revision) (flutter/engine#55328) 2024-09-21 skia-flutter-autoroll@skia.org Roll Skia from ca5731228de9 to 1be7027570a0 (1 revision) (flutter/engine#55327) 2024-09-21 skia-flutter-autoroll@skia.org Roll Skia from bdbbdee1db8c to ca5731228de9 (1 revision) (flutter/engine#55326) 2024-09-20 30870216+gaaclarke@users.noreply.github.com Adds vscode workspace with impeller test runner (flutter/engine#55291) 2024-09-20 skia-flutter-autoroll@skia.org Roll Skia from 16f53694ec96 to bdbbdee1db8c (1 revision) (flutter/engine#55321) 2024-09-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 21402561f6d3 to 419aef963b5a (1 revision) (flutter/engine#55320) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Adds vscode workspace with impeller test runner

a92fa8b

gaaclarke requested review from jtmcdole and matanlurey September 18, 2024 22:58

not sure why, but these have to be named like this which will interfe…

248b6a5

…re with linux

This comment was marked as outdated.

Sign in to view

gaaclarke added 4 commits September 18, 2024 16:16

added my launch entry too for debugging

6cc133a

added test adapter

9ed6597

added source map for the debugger - works from launch ui, not from de…

c5c0093

…bug test ui =(

got source map working for the test menu

e5497d5

jtmcdole reviewed Sep 19, 2024

View reviewed changes

license update

1add07a

gaaclarke requested a review from jtmcdole September 19, 2024 20:00

gaaclarke mentioned this pull request Sep 19, 2024

Adds tools/json_injector #55309

Closed

8 tasks

gaaclarke added 2 commits September 20, 2024 09:06

license exception

f85b45c

tool signature

3fd5371

jtmcdole approved these changes Sep 20, 2024

View reviewed changes

gaaclarke merged commit 1b28c20 into flutter:main Sep 20, 2024
27 checks passed

gaaclarke mentioned this pull request Sep 20, 2024

Made YAML version of vscode workspace to avoid redundancy #55322

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request Sep 22, 2024

Roll Flutter Engine from 0155f8fc4569 to 2504f8f17e9e (8 revisions) flutter/flutter#155511

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2024

1b28c2068 Adds vscode workspace with impeller test runner (flutter/en…

f9b92e0

…gine#55291)

engine-flutter-autoroll mentioned this pull request Sep 22, 2024

Roll Flutter Engine from 0155f8fc4569 to 2504f8f17e9e (8 revisions) flutter/flutter#155513

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2024

1b28c2068 Adds vscode workspace with impeller test runner (flutter/en…

c424dee

…gine#55291)

engine-flutter-autoroll mentioned this pull request Sep 23, 2024

Roll Flutter Engine from 0155f8fc4569 to 2504f8f17e9e (8 revisions) flutter/flutter#155515

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 23, 2024

1b28c2068 Adds vscode workspace with impeller test runner (flutter/en…

fe6ee23

…gine#55291)

engine-flutter-autoroll mentioned this pull request Sep 23, 2024

Roll Flutter Engine from 0155f8fc4569 to c11e75b9842a (9 revisions) flutter/flutter#155524

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 23, 2024

1b28c2068 Adds vscode workspace with impeller test runner (flutter/en…

1333870

…gine#55291)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds vscode workspace with impeller test runner #55291

Adds vscode workspace with impeller test runner #55291

gaaclarke commented Sep 18, 2024

flutter-dashboard bot commented Sep 18, 2024

This comment was marked as outdated.

jtmcdole Sep 19, 2024

gaaclarke Sep 19, 2024

gaaclarke commented Sep 19, 2024

gaaclarke commented Sep 19, 2024

jtmcdole left a comment

gaaclarke commented Sep 20, 2024

Adds vscode workspace with impeller test runner #55291

Adds vscode workspace with impeller test runner #55291

Conversation

gaaclarke commented Sep 18, 2024

Pre-launch Checklist

flutter-dashboard bot commented Sep 18, 2024

This comment was marked as outdated.

jtmcdole Sep 19, 2024

Choose a reason for hiding this comment

gaaclarke Sep 19, 2024

Choose a reason for hiding this comment

gaaclarke commented Sep 19, 2024

gaaclarke commented Sep 19, 2024

jtmcdole left a comment

Choose a reason for hiding this comment

gaaclarke commented Sep 20, 2024