[canvaskit] Fix incorrect calculation of ImageFilter paint bounds #54980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @eyebrowsoffire based on the screenshot goldens, the bug seems to still exist in Skwasm. |
harryterkelsen
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2024
zanderso
added a commit
to flutter/flutter
that referenced
this pull request
Sep 6, 2024
flutter/engine@c50eb8a...419fb8c 2024-09-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] always force platform channel responses to schedule a task. (#54975)" (flutter/engine#55000) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Skia from b6bab0fde426 to 6ad117bd2efe (2 revisions) (flutter/engine#54999) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Fuchsia Test Scripts from D9INMR2u4wcyiZ750... to 5dqcFlKzRjJb6V95W... (flutter/engine#54998) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Skia from a09312b70d37 to b6bab0fde426 (3 revisions) (flutter/engine#54997) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Skia from 368f209ccca5 to a09312b70d37 (1 revision) (flutter/engine#54995) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Skia from aec11ae18bb6 to 368f209ccca5 (3 revisions) (flutter/engine#54992) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Fuchsia Linux SDK from xNv47d1TZmK9XgTxu... to PBeI0gGvgFdXV6hCg... (flutter/engine#54990) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Skia from 809f868ded1c to aec11ae18bb6 (22 revisions) (flutter/engine#54988) 2024-09-06 [30870216+gaaclarke@users.noreply.github.com](mailto:30870216+gaaclarke@users.noreply.github.com) Removes the int storage from Color (flutter/engine#54714) 2024-09-06 [chris@bracken.jp](mailto:chris@bracken.jp) iOS,macOS: Add logging of duplicate codesign binaries (flutter/engine#54987) 2024-09-06 [skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org) Roll Fuchsia Test Scripts from k4lKsecg0pdIp-U7c... to D9INMR2u4wcyiZ750... (flutter/engine#54984) 2024-09-05 [a-siva@users.noreply.github.com](mailto:a-siva@users.noreply.github.com) Manual roll of Dart. (flutter/engine#54983) 2024-09-05 [chris@bracken.jp](mailto:chris@bracken.jp) iOS,macOS: add unsigned_binaries.txt (flutter/engine#54977) 2024-09-05 [jason-simmons@users.noreply.github.com](mailto:jason-simmons@users.noreply.github.com) Manual Skia roll to 809f868ded1c (flutter/engine#54972) 2024-09-05 [1961493+harryterkelsen@users.noreply.github.com](mailto:1961493+harryterkelsen@users.noreply.github.com) [canvaskit] Fix incorrect calculation of ImageFilter paint bounds (flutter/engine#54980) 2024-09-05 [jonahwilliams@google.com](mailto:jonahwilliams@google.com) [engine] always force platform channel responses to schedule a task. (flutter/engine#54975) 2024-09-05 [tugorez@users.noreply.github.com](mailto:tugorez@users.noreply.github.com) Fix unexpected ViewFocus events when Text Editing utilities change focus in the middle of a blur call. (flutter/engine#54965) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from xNv47d1TZmK9 to PBeI0gGvgFdX --------- Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes calculation of
ImageFilterbounds by taking into account the offset.Fixes flutter/flutter#154303
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.