[CP-stable]Reland (x2) "Output .js files as ES6 modules. (flutter#52023)" #54446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er#53718) Second attempt to reland flutter#52023 Fixes since the previous reland attempt: * We need to pass the skwasm main JS URI when loading the module so that it can pass that along to the worker. Since the worker uses the workaround to allow a cross script worker, it has trouble locating the main JS URI in relation to itself in a way that actually works for dynamic imports, so passing it along fixes that issue. * Some of the Google3 tests relied on the relative default canvaskit path. Dynamic module imports seems to not handle relative paths the way we expect, so we do our own URL resolution using the URL constructor before passing it into the dynamic import API. Also cleaned up some of the other relative pathing stuff that we do around the base URI. in flutter.js
flutteractionsbot
added
the
cp: review
|
@mdebbar please fill out the PR description above, afterwards the release team will review this request. |
7 tasks
|
@kevmoo seems like this might also impact issues from #153077 #152995. Maybe closes them out as well? |
eyebrowsoffire
approved these changes
Aug 12, 2024
yjbanov
approved these changes
Aug 13, 2024
itsjustkevin
added
the
autosubmit
auto-submit
bot
merged commit 46c417b
into
flutter:flutter-3.24-candidate.0
28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
Uncaught Error: Mismatched anonymous define() module: () => CanvasKitInitflutter#152844Changelog Description:
Fixes the loading of CanvasKit in a way that avoids app crashes and timeout issues.
Impact Description:
When CanvasKit is downloaded from the network (not cached), there's a high likelihood that the app crashes and displays a blank screen.
Workaround:
If the browser cache is enabled, users can refresh the page to get CanvasKit from cache and avoid the issue.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
--web-renderer=canvaskit.Disable cachecheckbox.