Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Upgrade all[most] androidx dependencies to latest" #53462

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Jun 18, 2024

Relands #53001.

Also pulls in @matanlurey's dependency on androidx.lifecycle:lifecycle-process, and upgrades it to 2.7.0.

It is unblocked by the changes in flutter/flutter#149204.

Tested by building the engine, and then also by building the flutter/packages all_packages app on this branch, so that hopefully it will also roll smoothly into the packages repo.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall marked this pull request as ready for review June 18, 2024 20:39
@gmackall gmackall requested review from a team and matanlurey June 18, 2024 20:39
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2024
@auto-submit auto-submit bot merged commit 0e3e68f into flutter:main Jun 18, 2024
33 checks passed
@justinmc
Copy link
Contributor

Thanks so much for the work here and in flutter/flutter#149204 to upgrade this! I really appreciate it for the scribe project 🙏.

@gmackall
Copy link
Member Author

Reason for revert: blocking roll (see flutter/flutter#150465 (comment)).

@gmackall gmackall added the revert Label used to revert changes in a closed and merged pull request. label Jun 19, 2024
auto-submit bot pushed a commit that referenced this pull request Jun 19, 2024
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Jun 19, 2024
auto-submit bot added a commit that referenced this pull request Jun 19, 2024
…53462)" (#53468)

Reverts: #53462
Initiated by: gmackall
Reason for reverting: blocking roll (see flutter/flutter#150465 (comment)).
Original PR Author: gmackall

Reviewed By: {reidbaker}

This change reverts the following previous change:
Relands #53001.

Also pulls in @matanlurey's dependency on `androidx.lifecycle:lifecycle-process`, and upgrades it to `2.7.0`.

It is unblocked by the changes in flutter/flutter#149204.

Tested by building the engine, and then also by building the `flutter/packages` `all_packages` app on this branch, so that hopefully it will also roll smoothly into the packages repo.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 19, 2024
…150473)

flutter/engine@0ad18fe...a312793

2024-06-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland "Upgrade all[most] androidx dependencies to latest" (#53462)" (flutter/engine#53468)
2024-06-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f1642cd8bed to 1f97ab20d078 (1 revision) (flutter/engine#53465)
2024-06-18 skia-flutter-autoroll@skia.org Roll Skia from f0bab26f6818 to 24a4123fc949 (2 revisions) (flutter/engine#53464)
2024-06-18 34871572+gmackall@users.noreply.github.com Reland "Upgrade all[most] androidx dependencies to latest" (flutter/engine#53462)
2024-06-18 skia-flutter-autoroll@skia.org Roll Skia from 1675eeabb289 to f0bab26f6818 (2 revisions) (flutter/engine#53459)
2024-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TwoeJy5Tn0ARHF5O4... to u8WOst9tlXsVQ02eJ... (flutter/engine#53461)
2024-06-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7245875f5191 to 7f1642cd8bed (1 revision) (flutter/engine#53460)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from TwoeJy5Tn0AR to u8WOst9tlXsV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@gmackall
Copy link
Member Author

Planning to re-land this once flutter/flutter#150585 lands

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 21, 2024
…utter_gallery`, roll pub packages (#150585)

Removes these two discontinued plugins from `dev/integration_tests/flutter_gallery`

[`device_info`](https://pub.dev/packages/device_info):
Apparently the video playback doesn't work on iOS simulators (I wasn't able to verify this, as I don't have an iOS simulator installed). I removed the guard against running on those simulators, and replaced with a note in the README.

[`connectivity`](https://pub.dev/packages/connectivity):
This plugin was used to play the bee video from the network. I changed the demo so that the bee video is instead also played from an asset (like its friend the butterfly), and then removed the use of the plugin.

Unblocks the re-land of flutter/engine#53462 (itself a reland �), because of #150465 (comment).
auto-submit bot pushed a commit that referenced this pull request Jun 24, 2024
Re-re-land #53001

(Reland attempt was at #53462)

Unblocked by flutter/flutter#150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles.

Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on flutter/flutter#149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot added a commit that referenced this pull request Jun 25, 2024
…t" (#53532)" (#53546)

Reverts: #53532
Initiated by: gmackall
Reason for reverting: This breaks apps that use plugins that use compileSdk 31, some of which we use in our postsubmit (so it blocks the tree).
Original PR Author: gmackall

Reviewed By: {reidbaker, matanlurey}

This change reverts the following previous change:
Re-re-land #53001

(Reland attempt was at #53462)

Unblocked by flutter/flutter#150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles.

Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on flutter/flutter#149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
sigurdm pushed a commit to sigurdm/flutter that referenced this pull request Jun 26, 2024
…utter_gallery`, roll pub packages (flutter#150585)

Removes these two discontinued plugins from `dev/integration_tests/flutter_gallery`

[`device_info`](https://pub.dev/packages/device_info):
Apparently the video playback doesn't work on iOS simulators (I wasn't able to verify this, as I don't have an iOS simulator installed). I removed the guard against running on those simulators, and replaced with a note in the README.

[`connectivity`](https://pub.dev/packages/connectivity):
This plugin was used to play the bee video from the network. I changed the demo so that the bee video is instead also played from an asset (like its friend the butterfly), and then removed the use of the plugin.

Unblocks the re-land of flutter/engine#53462 (itself a reland �), because of flutter#150465 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants