[CP-stable]Fix another instance of platform view breakage on Android 14 #52982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#52980) When you background an activity via the back-gesture the onTrimMemory callback is not invoked but the buggy Android behaviour still occurs. Workaround this by faking an onTrimMemory callback in the `Activity#onStop` callback. Fixes #148662 Related #146499 Tested manually on a Pixel 7 Pro running Android 14.
flutteractionsbot
added
the
cp: review
|
@reidbaker please fill out the PR description above, afterwards the release team will review this request. |
johnmccutchan
approved these changes
May 22, 2024
Fix whitespace formatting
reidbaker
approved these changes
May 28, 2024
itsjustkevin
added
the
autosubmit
auto-submit
bot
merged commit 1801d3b
into
flutter:flutter-3.22-candidate.0
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link
Fixes flutter/flutter#148662
CP bug flutter/flutter#148885
Target
stable
PR Link
TBD
Changelog Description
Platform view fix for android 14 when multiple activities are used and onMemoryTrim is called.
Impacted Users
Users shipping flutter apps on android 14 that use platform viewss
Impact Description
Platform views stop rendering new frames.
Workaround
No app level work around.
Risk
low
Test Coverage
no
Validation Steps
App is launched
App is backgrounded (via a back-gesture swipe)
Android Bug triggers HERE
no onTrimMemory callback fires
App is resumed
Platform views don't render