Update file permissions for FlutterMacOS.framework bundle #52961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cbracken
reviewed
May 21, 2024
jmagman
commented
May 21, 2024
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 22, 2024
…148819) flutter/engine@c89defa...b6971cd 2024-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HHwlAJN5imwf3yX4i... to gWBn6yPljFeQvPSYz... (flutter/engine#52975) 2024-05-22 bdero@google.com [Impeller] Round out subpass coverage. (flutter/engine#52973) 2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 968e971e438e to 78069713e02a (1 revision) (flutter/engine#52974) 2024-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from f0ac30bbc63e to fca7dd796e81 (1 revision) (flutter/engine#52972) 2024-05-21 ditman@gmail.com [web] Adds Noto Serif Tibetan fallback font. (flutter/engine#52971) 2024-05-21 magder@google.com Update file permissions for FlutterMacOS.framework bundle (flutter/engine#52961) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from HHwlAJN5imwf to gWBn6yPljFeQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#148819) flutter/engine@c89defa...b6971cd 2024-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HHwlAJN5imwf3yX4i... to gWBn6yPljFeQvPSYz... (flutter/engine#52975) 2024-05-22 bdero@google.com [Impeller] Round out subpass coverage. (flutter/engine#52973) 2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 968e971e438e to 78069713e02a (1 revision) (flutter/engine#52974) 2024-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from f0ac30bbc63e to fca7dd796e81 (1 revision) (flutter/engine#52972) 2024-05-21 ditman@gmail.com [web] Adds Noto Serif Tibetan fallback font. (flutter/engine#52971) 2024-05-21 magder@google.com Update file permissions for FlutterMacOS.framework bundle (flutter/engine#52961) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from HHwlAJN5imwf to gWBn6yPljFeQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 18, 2024
Framework test to validate the iOS and macOS framework engine artifacts (Flutter.framework and FlutterMacOS.framework) have read and executable permissions. ~~Will fail until flutter/engine#52961 rolls.~~ <-- it rolled #148819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo from #52930. The entire framework bundle/directory needs 755 perms (not recursive), but that PR instead updated the binary within the framework bundle.
Once this rolls I'll rebase flutter/flutter#148786 and merge that test.
Engine-side fix for flutter/flutter#148354