[Impeller] remove shared_ptr copy/release in main rendering loop. #49801
Conversation
jonahwilliams
commented
Jan 16, 2024
jonahwilliams
commented
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: non-semantic refactor. |
jonahwilliams
added
autosubmit
|
Added some more PTAL |
LGTM! Psst, next time use this feature: 
|
jonahwilliams
added
the
autosubmit
…141643) flutter/engine@eab7bd3...d4b6b7e 2024-01-16 jonahwilliams@google.com [Impeller] remove shared_ptr copy/release in main rendering loop. (flutter/engine#49801) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
