Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks in some embedder unit tests that send key events #49548

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

jason-simmons
Copy link
Member

FlutterEngineSendKeyEvent sends a platform message. The test's embedder configuration must have a platform message callback that calls FlutterEngineSendPlatformMessageResponse to free the message's response handle.

FlutterEngineSendKeyEvent sends a platform message.  The test's embedder configuration must have a platform message callback that calls FlutterEngineSendPlatformMessageResponse to free the message's response handle.
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2024
@auto-submit auto-submit bot merged commit ee1ded6 into flutter:main Jan 8, 2024
27 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 8, 2024
…141133)

flutter/engine@00ff332...ee1ded6

2024-01-08 jason-simmons@users.noreply.github.com Fix memory leaks in some embedder unit tests that send key events (flutter/engine#49548)
2024-01-08 jason-simmons@users.noreply.github.com [Impeller] Start and end a frame in the RenderTargetCache for each rendering of an entity in the playgrounds (flutter/engine#49576)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants