[Flutter GPU] Shader bundle improvements: Uniform structs & member offset reflection, GLES metadata, separate from runtime stage. #49485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdero
commented
Jan 3, 2024
bdero
commented
- Switch from legacy uniform semantics to uniform structs.
- Completely separate shader bundle from runtime stage.
- Packing multiple backends per shader.
- Pack struct and member fields into the shader bundle flatbuffer.
- Bind uniforms with correct metadata for GLES.
- Add uniform struct size and member offset reflection.
bdero
changed the title
bdero
force-pushed
the
bdero/flutter-gpu-uniforms
branch
2 times, most recently
from
fa7ccf1
to
f3de8ba
Compare
Add ShaderBundleData Pack struct and member fields into the shader bundle flatbuffer Unpack new shader bundle Wire up new uniforms
bdero
force-pushed
the
bdero/flutter-gpu-uniforms
branch
from
8d620d8
to
65d5c56
Compare
bdero
force-pushed
the
bdero/flutter-gpu-uniforms
branch
from
65d5c56
to
94e6194
Compare
|
Okay, this is finally at a point where I'm mostly happy with it. I need to get a much less trivial example going to feel out how a fuller runtime reflection would work, if any (same would go for utilities like a swapchain/surface helper). Technically we don't actually need member reflection at all, since member alignment should be stable across the backends. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2024
… member offset reflection, GLES metadata, separate from runtime stage. (flutter/engine#49485)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 8, 2024
…141128) flutter/engine@70c4515...00ff332 2024-01-08 bdero@google.com [Flutter GPU] Shader bundle improvements: Uniform structs & member offset reflection, GLES metadata, separate from runtime stage. (flutter/engine#49485) 2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from 88b7612add02 to a0aba842460c (4 revisions) (flutter/engine#49600) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.