This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Revert "Reland "[Windows] Move to FlutterCompositor for rendering" #49461
Merged
auto-submit
merged 1 commit into
flutter:main
from
loic-sharma:revert_windows_compositor
Jan 2, 2024
Merged
Revert "Reland "[Windows] Move to FlutterCompositor for rendering" #49461
auto-submit
merged 1 commit into
flutter:main
from
loic-sharma:revert_windows_compositor
Jan 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3b62c7
to
ee0e814
Compare
…lutter#49262)" This reverts commit 00d7d23.
yaakovschectman
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor nit
@@ -327,8 +320,8 @@ bool FlutterWindow::OnBitmapSurfaceUpdated(const void* allocation, | |||
bmi.bmiHeader.biBitCount = 32; | |||
bmi.bmiHeader.biCompression = BI_RGB; | |||
bmi.bmiHeader.biSizeImage = 0; | |||
int ret = ::SetDIBitsToDevice(dc, 0, 0, row_bytes / 4, height, 0, 0, 0, | |||
height, allocation, &bmi, DIB_RGB_COLORS); | |||
int ret = SetDIBitsToDevice(dc, 0, 0, row_bytes / 4, height, 0, 0, 0, height, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a necessary part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't strictly necessary but for bookkeeping purposes I'd prefer to fully revert #49262. This will make the reland easier to review as there'll be fewer changes between the original PR and the reland.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 3, 2024
…140840) flutter/engine@b5e79bd...e95e123 2024-01-02 737941+loic-sharma@users.noreply.github.com Revert "Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49461) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects: desktop
autosubmit
Merge PR when tree becomes green via auto submit App
e: impeller
platform-linux
platform-windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #49262 (00d7d23) as it regressed
material_floating_search_bar
's animation.This revert was created manually due to merge conflicts.
Issue tracking bug: flutter/flutter#140828
Part of flutter/flutter#128904
Minimal repro of the broken animation...
Here's what the animation is supposed to look like:

Here's what the animation actually looks like:
Here is a minimal repro of the broken animation:
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.