This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34 #48811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoamador
approved these changes
Dec 8, 2023
camsim99
added
autosubmit
Adds comment for context.
camsim99
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/48811, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
camsim99
added
the
autosubmit
camsim99
added
the
revert
|
We missed the name mismatch 😭 will rename and reland. I am now, though, confused as to how my test run passed... |
8 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Dec 11, 2023
…n on AVDs with Android 33 & 34" (#48895) Reverts #48811 Initiated by: camsim99 This change reverts the following previous change: Original Description: Adds target (`Linux linux_android_emulator_tests_api_33`) to have Android emulator testst run on AVDs with Android 33 so that the differences between those tests runs and those running on AVDs with Android 34 (`Linux linux_android_emulator_tests`) may be observed. Related to flutter/flutter#137947. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 11, 2023
…un on AVDs with Android 33 & 34 (flutter/engine#48811)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 11, 2023
…139941) flutter/engine@5c1f13e...d001419 2023-12-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" (flutter/engine#48895) 2023-12-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 611fca7f0c20 to 53dfedb82222 (1 revision) (flutter/engine#48891) 2023-12-11 skia-flutter-autoroll@skia.org Roll Skia from e55567fceb5f to 17bd70326a49 (22 revisions) (flutter/engine#48890) 2023-12-11 43054281+camsim99@users.noreply.github.com [Android] Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34 (flutter/engine#48811) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
|
Getting re-landed in #48936. |
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
…n on AVDs with Android 33 & 34" (#48936) Re-lands #48811 with corrected config file name. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
auto-submit bot
added a commit
that referenced
this pull request
Dec 13, 2023
…_tests run on AVDs with Android 33 & 34"" (#48988) Reverts #48936 Initiated by: loic-sharma This change reverts the following previous change: Original Description: Re-lands #48811 with corrected config file name. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds target (
Linux linux_android_emulator_tests_api_33) to have Android emulator testst run on AVDs with Android 33 so that the differences between those tests runs and those running on AVDs with Android 34 (Linux linux_android_emulator_tests) may be observed.Related to flutter/flutter#137947.
Pre-launch Checklist
///).