Remove use of variable length arrays #48232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this affect any dependencies? |
zanderso
approved these changes
Nov 20, 2023
|
I was able to do a local After this lands we will need to restart the Clang roll and verify that all CI checks pass. |
|
The Fuchsia failures look unrelated. Does this just need to be rebased? |
The variable length array extension will be disabled by default in the next roll of Clang.
jason-simmons
force-pushed
the
clang_fix_variable_array
branch
from
c691dc1 to
d8dc084
Compare
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 28, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 28, 2023
…139178) flutter/engine@01fcec7...570fec4 2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from f07025afd712 to 6ad886e9593a (5 revisions) (flutter/engine#48469) 2023-11-28 jason-simmons@users.noreply.github.com Remove use of variable length arrays (flutter/engine#48232) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
…lutter#139178) flutter/engine@01fcec7...570fec4 2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from f07025afd712 to 6ad886e9593a (5 revisions) (flutter/engine#48469) 2023-11-28 jason-simmons@users.noreply.github.com Remove use of variable length arrays (flutter/engine#48232) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable length array extension will be disabled by default in the next roll of Clang.