Reland "[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching" #47824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Nov 8, 2023
bdero
approved these changes
Nov 8, 2023
flar
added
autosubmit
auto-submit
bot
deleted the
revert-47821-revert_2366ce60c19d81b7f288fe068dcddba3851dcc72
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 8, 2023
…sSimple needed for DL dispatching" (flutter/engine#47824)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 9, 2023
…138116) flutter/engine@b3af5d6...233bd62 2023-11-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Upgrade Android SDK to 34 "UpsideDownCake"" (flutter/engine#47834) 2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from e585bb68893b to 1241a903cd33 (2 revisions) (flutter/engine#47830) 2023-11-08 34871572+gmackall@users.noreply.github.com Upgrade Android SDK to 34 "UpsideDownCake" (flutter/engine#47609) 2023-11-08 chris@bracken.jp [macOS] Allocate textures as unique_ptr earlier (flutter/engine#47786) 2023-11-08 flar@google.com Reland "[Impeller] add support for Skia concept of RRect::isSimple needed for DL dispatching" (flutter/engine#47824) 2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from e2b8ebe16203 to e585bb68893b (7 revisions) (flutter/engine#47826) 2023-11-08 jonahwilliams@google.com [Impeller] Add support for specialization constants (III). (flutter/engine#47765) 2023-11-08 30870216+gaaclarke@users.noreply.github.com [Impeller] Documented the 2 step in the gaussian blur. (flutter/engine#47822) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #47821
The original PR was reverted because the Vulkan backends couldn't handle the extra tests, but they've since been patched to fix the problem.