Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build iOS unittest target in unopt builds #44301

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Build iOS unittest target in unopt builds #44301

merged 1 commit into from
Aug 3, 2023

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Aug 2, 2023

build ios unittest target in unopt builds.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz requested a review from cbracken August 2, 2023 22:28
@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2023
@auto-submit auto-submit bot merged commit 9c17c35 into flutter:main Aug 3, 2023
25 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2023
@engine-flutter-autoroll
9c17c35d1 Build iOS unittest target in unopt builds (flutter/engine#4…
1fb872b 
…4301)
cyanglaz pushed a commit that referenced this pull request Aug 3, 2023
Revert "Build iOS unittest target in unopt builds (#44301)"
c0d2b8c 
This reverts commit 9c17c35.
@cyanglaz cyanglaz mentioned this pull request Aug 3, 2023
Merged
eyebrowsoffire pushed a commit to flutter/flutter that referenced this pull request Aug 3, 2023
@engine-flutter-autoroll @zanderso
Roll Flutter Engine from b08e1410a06a to 0c1de9b8afba (9 revisions) (#…
fd000dc 
…131897)

flutter/engine@b08e141...0c1de9b

2023-08-03 yjbanov@google.com [web] fix clicks on merged semantic nodes
(flutter/engine#43620)
2023-08-03 john@johnmccutchan.com Remove WARNINGs from JNI load path as
we can't suppress them (flutter/engine#44348)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 872dc53233cf to
bae32428c1c7 (3 revisions) (flutter/engine#44341)
2023-08-03 ychris@google.com Build iOS unittest target in unopt builds
(flutter/engine#44301)
2023-08-03 chris@bracken.jp [darwin] Move common targets to
common/BUILD.gn (flutter/engine#44335)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 2babe68de295 to
872dc53233cf (2 revisions) (flutter/engine#44339)
2023-08-03 kjlubick@users.noreply.github.com Migrate GL calls of
GrBackend* (flutter/engine#44334)
2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from 36072a994f11 to
2babe68de295 (1 revision) (flutter/engine#44336)
2023-08-03 skia-flutter-autoroll@skia.org Roll Clang from 07c592048780
to 020d2fb7711d (flutter/engine#44332)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
auto-submit bot pushed a commit that referenced this pull request Aug 3, 2023
Revert "Build iOS unittest target in unopt builds" (#44356)
f35213f 
Reverts #44301

```
Traceback (most recent call last):
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 1286, in <module>
    sys.exit(main())
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 1269, in main
    run_objc_tests(args.ios_variant, args.objc_filter)
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 721, in run_objc_tests
    ensure_ios_tests_are_built(ios_out_dir)
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 625, in ensure_ios_tests_are_built
    assert flutter_dylib_time <= ios_test_lib_time, final_message
AssertionError: /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe/libios_test_flutter.dylib is older than /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe/libFlutter.dylib. Please run the following commands: 
gn --ios --unoptimized --runtime-mode=debug --no-lto --simulator
ninja -C /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe ios_test_flutter
```

It failed we in run_test.py we check if the ios_test is built after the framework, which is not true anymore after moving the test inside the build target.
@cyanglaz cyanglaz mentioned this pull request Aug 17, 2023
Merged
8 tasks
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
@gaaclarke
Build iOS unittest target in unopt builds (flutter#44301)
e783600 
build ios unittest target in unopt builds. 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
@gaaclarke
Revert "Build iOS unittest target in unopt builds" (flutter#44356)
1003a7d 
Reverts flutter#44301

```
Traceback (most recent call last):
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 1286, in <module>
    sys.exit(main())
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 1269, in main
    run_objc_tests(args.ios_variant, args.objc_filter)
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 721, in run_objc_tests
    ensure_ios_tests_are_built(ios_out_dir)
  File "/Volumes/Work/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 625, in ensure_ios_tests_are_built
    assert flutter_dylib_time <= ios_test_lib_time, final_message
AssertionError: /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe/libios_test_flutter.dylib is older than /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe/libFlutter.dylib. Please run the following commands: 
gn --ios --unoptimized --runtime-mode=debug --no-lto --simulator
ninja -C /Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe ios_test_flutter
```

It failed we in run_test.py we check if the ios_test is built after the framework, which is not true anymore after moving the test inside the build target.
auto-submit bot pushed a commit that referenced this pull request Aug 31, 2023
Reland "Build iOS unittest target in unopt builds" (#44356)" (#44821)
1d703f0 
Relands #44301

The original PR was reverted in #44356

The `assert flutter_dylib_time <= ios_test_lib_time, final_message` check is reverted in 70dd9e4, so we are safe to land this again. 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyanglaz @cbracken