Reland"[fuchsia][a11y] Set explicit hit regions per compositor layer…" #34386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or layer on GFX. (flutter#33852)" (flutter#34360)" This reverts commit 98b14f7.
|
cc @naudzghebre |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2022
…compositor layer on GFX. (flutter#33852)" (flutter#34360)" (flutter/engine#34386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #34360
The original change was implicated in a failing test in fuchsia that blocked a roll attempt. We discovered that the PR itself was working as intended, but exposed a floating point rounding error in scenic that resulted in the blocking test failure. We relaxed the failing test to accommodate the rounding error, so this PR should be safe to re-land as-is.