Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macos] [NSViewController viewWillAppear] can be called multiple times #34072

Merged
merged 1 commit into from
Jun 16, 2022
Merged

[macos] [NSViewController viewWillAppear] can be called multiple times #34072

merged 1 commit into from
Jun 16, 2022

Conversation

knopp
Copy link
Member

@knopp knopp commented Jun 15, 2022

Fixes flutter/flutter#105963

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chinmaygarde
Copy link
Member

cc @cbracken

@cbracken cbracken self-requested a review June 16, 2022 20:48
cbracken
cbracken approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cbracken cbracken merged commit 5fb4a53 into flutter:main Jun 16, 2022
@knopp knopp deleted the macos_view_will_appear_assertion branch June 16, 2022 20:52
@cbracken cbracken mentioned this pull request Jun 16, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
5fb4a53 [macos] [NSViewController viewWillAppear] can be called multi…
48df570 
…ple times (flutter/engine#34072)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
5fb4a53 [macos] [NSViewController viewWillAppear] can be called multi…
b4b7640 
…ple times (flutter/engine#34072)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
5fb4a53 [macos] [NSViewController viewWillAppear] can be called multi…
58114b9 
…ple times (flutter/engine#34072)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
5fb4a53 [macos] [NSViewController viewWillAppear] can be called multi…
aee192e 
…ple times (flutter/engine#34072)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
5fb4a53 [macos] [NSViewController viewWillAppear] can be called multi…
6229f23 
…ple times (flutter/engine#34072)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@knopp @houhuayong
[macos] [NSViewController viewWillAppear] can be called multiple times (
bd78089 
flutter#34072)

Fixes flutter/flutter#105963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

Assignees
No one assigned
Labels
platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[macOS] Assertion failed: _keyUpMonitor was already created
3 participants
@knopp @chinmaygarde @cbracken