Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Put FlutterTextInputPlugin in view hierarchy #33827

Merged
merged 14 commits into from
Jun 15, 2022
Merged

[macOS] Put FlutterTextInputPlugin in view hierarchy #33827

merged 14 commits into from
Jun 15, 2022

Commits on Jun 14, 2022

  1. Put FlutterTextInputPlugin in view hierarchy

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    d81de32 View commit details
    Browse the repository at this point in the history

  2. Add IsAddedAndRemovedFromViewHierarchy test

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    8d734cc View commit details
    Browse the repository at this point in the history

  3. Add TestPerformKeyEquivalent

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    b1eda1c View commit details
    Browse the repository at this point in the history

  4. Ensure no reentrancy

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    d6a2b0e View commit details
    Browse the repository at this point in the history

  5. Update comment

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    7d9c47f View commit details
    Browse the repository at this point in the history

  6. Remove previousResponder field

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    bc01986 View commit details
    Browse the repository at this point in the history

  7. Do not use becomeFirstResponder to start editing

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    99742bb View commit details
    Browse the repository at this point in the history

  8. Reparent FlutterTextPlugin to wrapper view when disabling accessibility

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    512404e View commit details
    Browse the repository at this point in the history

  9. typo

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    aeeb339 View commit details
    Browse the repository at this point in the history

  10. Remove nil check

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    89f1d8d View commit details
    Browse the repository at this point in the history

  11. Update tests

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    b8afeb5 View commit details
    Browse the repository at this point in the history

  12. Do not expose KeyboardManager from controller

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    997ae3f View commit details
    Browse the repository at this point in the history

  13. Remove unused import

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    d7f43fa View commit details
    Browse the repository at this point in the history

  14. Remove from superview in TextInput.clearClient

    @knopp
    knopp committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    74b21fe View commit details
    Browse the repository at this point in the history