Do not create incomplete DlColorSource objects from Skia gradients #33131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
May 5, 2022
|
This just needs a rebase. |
|
This issue was introduced in 70c1173 and should be a CP candidate. |
flar
force-pushed
the
avoid-creating-incomplete-ColorSource-from-Skia-gradient
branch
from
ec9aa19
to
8a8398a
Compare
flar
added
the
waiting for tree to go green
flar
added a commit
to flar/engine
that referenced
this pull request
May 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2022
This was referenced May 6, 2022
flar
added a commit
to flar/engine
that referenced
this pull request
May 18, 2022
XilaiZhang
pushed a commit
that referenced
this pull request
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: flutter/flutter#102947
Unfortunately, this fix will break gradients in text objects using the Impeller pipeline - see flutter/flutter#103111 which will be used to track a more complete solution that restores the Impeller capabilities.