[web] Fix leaking canvas in text placeholder tests #21253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
reviewed
Sep 17, 2020
| @@ -39,6 +40,7 @@ void testMain() async { | |||
| ); | |||
| offset = offset.translate(0.0, 80.0); | |||
| } | |||
| recordingCanvas.restore(); | |||
There was a problem hiding this comment.
i just see save/restore pairs. why was it leaking when restore is not called ?
There was a problem hiding this comment.
Because of the way canvas pool works lazily now? I saw you added restore calls in multiple tests: #15153
nturgut
reviewed
Sep 17, 2020
| @@ -104,7 +104,7 @@ class IosSafariArgParser extends BrowserArgParser { | |||
| ); | |||
| } catch (e) { | |||
| throw Exception('Error getting requested simulator. Try running ' | |||
| '`felt create` command first before running the tests. Exception: ' | |||
| '`felt create_simulator` command first before running the tests. Exception: ' | |||
nturgut
approved these changes
Sep 17, 2020
nturgut
reviewed
Sep 17, 2020
| @@ -397,7 +397,8 @@ class TestCommand extends Command<bool> with ArgUtils { | |||
| // after solving the git issue faced on macOS and Windows bots: | |||
| // TODO: https://github.com/flutter/flutter/issues/63710 | |||
| if ((isChrome && isLuci && io.Platform.isLinux) || | |||
| ((isChrome || isSafariIOS) && !isLuci)) { | |||
There was a problem hiding this comment.
can you remove this part for now :) I didn't merged the recipe change
|
Never mind. This PR doesn't fix anything. The tests started passing for me on master, but failing for Nurhan. Filed an issue: flutter/flutter#66129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The text placeholder test used to leak canvases which led to errors in iOS Safari because it stops creating canvases after some time. This PR fixes the leakage.
cc @ferhatb to confirm this is the right way to fix the leakage.