Flutter 1.22.0-12.1.pre engine cherrypicks #21188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
christopherfujino
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
LGTM regarding the commits. I took a look at @blasten 's commit and it looks ok, but it's non-trivial so he should also confirm.
Also, here's the license diff:
--- flutter/ci/licenses_golden/licenses_third_party 2020-09-15 19:23:29.109948078 +0000
+++ out/license_script_output/licenses_third_party 2020-09-15 19:36:39.671359357 +0000
@@ -1,7 +1,7 @@
-Signature: 14693ed982fa820c5dbce3c385be0a60
+Signature: a1bbcd05a2657658be7c5f38e0d366f4
|
Thanks Patrick! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update Dart to 2.10.0-110.3.beta
External view embedder shouldn't submit frame if threads aren't merged on iOS flutter#65404