New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Implement ulps for path ops #19711

Merged

ferhatb merged 4 commits into flutter:master from ferhatb:ulps1

Jul 13, 2020

Contributor

ferhatb commented Jul 13, 2020

Description

Add library for floating point stability of path ops.

Related Issues

Related: flutter/flutter#44572

Tests

I added the following tests:

ulps_test.dart

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the [contributor guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [C++, Objective-C, Java style guides] for the engine.
I read the [tree hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [handling breaking changes].

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes


          Implement ulps for path ops

902cd30

ferhatb requested review from yjbanov and harryterkelsen

July 13, 2020 17:12

googlebot added the cla: yes label

yjbanov approved these changes

View reviewed changes

lib/web_ui/lib/src/engine/ulps.dart Outdated

+              /// Converts a sign-bit int (float interpreted as int) into a 2s complement
+              /// int. Also converts 0x80000000 to 0. Allows result to be compared using
+              /// int comparison.
+              int signBitTo2sCompliment(int x) => (x & 0x80000000) != 0 ? (-(x & 0x7fffffff)) : x;

Contributor

yjbanov Jul 13, 2020

compliment => complement (applies throughout the file)

Contributor Author

ferhatb Jul 13, 2020

Done.

lib/web_ui/lib/src/engine/ulps.dart

+              int signBitTo2sCompliment(int x) => (x & 0x80000000) != 0 ? (-(x & 0x7fffffff)) : x;
+              /// Convert a 2s compliment int to a sign-bit (i.e. int interpreted as float).
+              int twosComplimentToSignBit(int x) {

Contributor

yjbanov Jul 13, 2020

Does this work on arbitrary ranges of values? Same question for signBitTo2sCompliment.

Contributor Author

ferhatb Jul 13, 2020

Added tests to cover ranges.

lib/web_ui/lib/src/engine/ulps.dart Outdated

+                final Float32List float32List = Float32List(1);
+                late Int32List int32List;
+                _FloatBitConverter() {
+                  int32List = float32List.buffer.asInt32List(0, 1);

Contributor

yjbanov Jul 13, 2020

late has some cost, because it is compiled into a function. If you move the initialization into the initializer list, you can make it final, which is free. You may need to use a factory though, because the two fields are backed by the same buffer.

Contributor Author

ferhatb Jul 13, 2020

Done.

lib/web_ui/lib/src/engine/ulps.dart Outdated

+              }
+              // Singleton bit converter to prevent typed array allocations.
+              _FloatBitConverter _floatBitConverter = _FloatBitConverter();

Contributor

yjbanov Jul 13, 2020

final?

Contributor Author

ferhatb Jul 13, 2020

Done.

lib/web_ui/lib/src/engine/ulps.dart

+              _FloatBitConverter _floatBitConverter = _FloatBitConverter();
+              // Converts float to bits.
+              int float2Bits(Float32List source, int index) {

Contributor

yjbanov Jul 13, 2020

Why not take a double?

Contributor Author

ferhatb Jul 13, 2020

Will pass pathRef.points array directly to this api. See toBits that uses double as input.

lib/web_ui/lib/src/engine/ulps.dart Outdated

+                  float32List[0] = x;
+                  return int32List[0];
+                }
+                double toFloat(int bits) {

Contributor

yjbanov Jul 13, 2020

toDouble or toFloat64? "Float" implies 32 bits, but this returns a 64-bit value.

Member

ditman Jul 13, 2020

+1

Contributor Author

ferhatb Jul 13, 2020

Done.

lib/web_ui/lib/src/engine/ulps.dart

+                return aBits < bBits + epsilon && bBits < aBits + epsilon;
+              }
+              bool almostEqualUlps(double a, double b) {

Contributor

yjbanov Jul 13, 2020

Docs? (applies here and other undocumented functions)

Contributor Author

ferhatb Jul 13, 2020

Done.

lib/web_ui/lib/src/engine/ulps.dart Outdated

+                return equalUlps(a, b, kUlpsEpsilon, kUlpsEpsilon);
+              }
+              // Equality using the same error term as between

Contributor

yjbanov Jul 13, 2020

Does this doc comment need an ending?

Contributor Author

ferhatb Jul 13, 2020

Done.

lib/web_ui/lib/src/engine/ulps.dart Outdated

+              }
+              bool almostDequalUlpsDouble(double a, double b) {
+                if (a.abs() < kScalarMax && b.abs() < kScalarMax) {

Contributor

yjbanov Jul 13, 2020

Maybe cache a.abs() and b.abs()? They are also used below on line 170.

Contributor Author

ferhatb Jul 13, 2020

Done.

lib/web_ui/lib/src/engine/ulps.dart

+              // Use of this source code is governed by a BSD-style license that can be
+              // found in the LICENSE file.
+              part of engine;

Contributor

yjbanov Jul 13, 2020

Is there a Skia file(s) we can point to where this was ported from?

Contributor Author

ferhatb Jul 13, 2020

Added link.

ditman approved these changes

View reviewed changes

Member

ditman left a comment

My only suggestion would be to make this code a separate library that you can import '...' as ulps; or similar (instead of part of engine;) in order not to add a lot of ulp-related methods to the API of the engine itself, but if this is how things are normally done in the engine, ship it!

lib/web_ui/lib/src/engine/ulps.dart Outdated Show resolved Hide resolved

lib/web_ui/lib/src/engine/ulps.dart Show resolved Hide resolved

ferhatb added 3 commits

July 13, 2020 11:37


          Address review comments

052c631


          cache abs()

c067c45


          dartfmt and update licenses

062960a

ferhatb merged commit df23044 into flutter:master

engine-flutter-autoroll mentioned this pull request

Roll Engine from f10f17257300 to d024ae400949 (49 revisions) flutter/flutter#61396

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request


          df23044 [web] Implement ulps for path ops (flutter/engine#19711)

bfc9942

engine-flutter-autoroll mentioned this pull request

Roll Engine from f10f17257300 to ae379712188a (53 revisions) flutter/flutter#61404

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request


          df23044 [web] Implement ulps for path ops (flutter/engine#19711)

b522838

engine-flutter-autoroll mentioned this pull request

Roll Engine from f10f17257300 to 1e23309a386e (55 revisions) flutter/flutter#61410

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request


          df23044 [web] Implement ulps for path ops (flutter/engine#19711)

63f895f

engine-flutter-autoroll mentioned this pull request

Roll Engine from f10f17257300 to 1e23309a386e (55 revisions) flutter/flutter#61435

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request


          df23044 [web] Implement ulps for path ops (flutter/engine#19711)

ef42156

GaryQian pushed a commit to flutter/flutter that referenced this pull request


          Roll Engine from f10f172 to 1e23309 (55 revisions) (#61435)

ce55e42

* 160b268 Set locale in Linux shell (flutter/engine#19470)

* c479b93 Fix documentation of unset platform view ID (flutter/engine#19320)

* f3ab78d Fix clipboard paste functionality not working (flutter/engine#19489)

* 9345347 Added the ability to set properties in interface builder for FlutterViewController. (flutter/engine#19458)

* 69fdf6d Use identical in hashValues instead of operator== (flutter/engine#19615)

* 3dc8163 [android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak (flutter/engine#19620)

* b16c47d using text capitalization value in web (flutter/engine#19564)

* 49c0161 Roll Skia from 16bf7d31c819 to 4d48bb35972f (32 revisions) (flutter/engine#19635)

* 2d6afa7 Roll Skia from 4d48bb35972f to 9f821489c9f3 (4 revisions) (flutter/engine#19638)

* 35f59b9 Roll Fuchsia Linux SDK from NC9pp... to 5R9a0... (flutter/engine#19639)

* 53038e2 Roll Fuchsia Mac SDK from iwQCA... to Wym-S... (flutter/engine#19640)

* d9e68f4 Roll Skia from 9f821489c9f3 to f8a6b5b4b0d0 (1 revision) (flutter/engine#19643)

* d329617 Changes to fix build errors in google3. (flutter/engine#19616)

* dd0a6c4 Roll Skia from f8a6b5b4b0d0 to 5160e8caa226 (9 revisions) (flutter/engine#19647)

* d98d539 Manual Roll of Dart dfdc7e45c5...06cb010247 (flutter/engine#19649)

* dfd0727 don't throw error for the new autofill request (flutter/engine#19633)

* 39e98d2 Manual Skia roll to c91db040ad18b9cc3236e342e9acca020eaafd10 (flutter/engine#19650)

* f9acd08 Avoid a copy in EncodeImage (flutter/engine#19504)

* 7e101f1 Roll Fuchsia Linux SDK from 5R9a0... to GOf1K... (flutter/engine#19656)

* f3be9f1 Incorporate compat info changes into flutter engine (flutter/engine#19606)

* 9188ff6 Manual Roll of Dart 707c6404f9...dfdc7e45c5 (flutter/engine#19657)

* cbdd3e2 Roll Fuchsia Mac SDK from Wym-S... to -v4bL... (flutter/engine#19661)

* 6efb152 Roll Dart SDK from 707c6404f969 to 0e25306d3f78 (4 revisions) (flutter/engine#19666)

* 22a440c Roll Dart SDK from 0e25306d3f78 to 6d06476bae6b (1 revision) (flutter/engine#19669)

* 8063923 Roll Fuchsia Linux SDK from GOf1K... to QWI76... (flutter/engine#19671)

* c99deb0 CkPaint uses SkPaint (flutter/engine#19562)

* 015f2ea Use the main bundle if the App bundle is not found (flutter/engine#18749)

* f82d30b Roll Dart SDK from 6d06476bae6b to a9e67d81941a (3 revisions) (flutter/engine#19677)

* 61b2fd2 Roll Fuchsia Mac SDK from -v4bL... to phQJt... (flutter/engine#19681)

* 74b541d Roll Fuchsia Linux SDK from QWI76... to mrlGt... (flutter/engine#19682)

* 25ce3db Roll Skia from c91db040ad18 to e4f36d7ac8f5 (20 revisions) (flutter/engine#19686)

* 162dba1 Roll Skia from e4f36d7ac8f5 to ed15b1c39b8b (1 revision) (flutter/engine#19687)

* f97c38b Roll Fuchsia Mac SDK from phQJt... to kEVc6... (flutter/engine#19688)

* 40c4ee8 Roll Fuchsia Linux SDK from mrlGt... to YfVT0... (flutter/engine#19690)

* ec944b0 Roll Skia from ed15b1c39b8b to 1434ce1aa94d (1 revision) (flutter/engine#19692)

* 7ce988a Roll Skia from 1434ce1aa94d to f64be13cbf84 (2 revisions) (flutter/engine#19695)

* 5f7ca41 Roll Fuchsia Mac SDK from kEVc6... to hRul_... (flutter/engine#19696)

* d24549c Roll Skia from f64be13cbf84 to 041796e60364 (3 revisions) (flutter/engine#19697)

* 617bd88 Roll Dart SDK from a9e67d81941a to fecc8163afc7 (3 revisions) (flutter/engine#19703)

* 8d241e4 [Android] Prevent FlutterRenderer listener from calling JNI after detach (flutter/engine#19558)

* 309e514 Roll Skia from 041796e60364 to d1ce4cb2beb8 (2 revisions) (flutter/engine#19704)

* 211f18e Roll Skia from d1ce4cb2beb8 to 7c1967700b44 (6 revisions) (flutter/engine#19707)

* 0532227 Roll Skia from 7c1967700b44 to 439709a97dfd (8 revisions) (flutter/engine#19712)

* 1e02bfd Support decimal information on the TextInputType (flutter/engine#19664)

* 7a95e32 Linux: Use a hash table to map cursors (flutter/engine#19561)

* df23044 [web] Implement ulps for path ops (flutter/engine#19711)

* 4a3aa4d Fixes typo in android_context_gl.h (flutter/engine#19700)

* 5b966eb Roll Skia from 439709a97dfd to 2604a89d3353 (3 revisions) (flutter/engine#19715)

* d024ae4 [fuchsia] Use memory_requirements_2 extension. (flutter/engine#19678)

* 4392fbf Roll Fuchsia Linux SDK from YfVT0... to 2ct5j... (flutter/engine#19720)

* ab05c79 Roll Fuchsia Mac SDK from hRul_... to ZXLvD... (flutter/engine#19721)

* c05ca7e Roll Dart SDK from fecc8163afc7 to f997d62a6d29 (13 revisions) (flutter/engine#19722)

* ae37971 Remove xcpretty from unit tests to see full output on test failures (flutter/engine#19667)

* 91f80ef Moved to RMSE for image comparison to account for slight variations in golden image tests (flutter/engine#19658)

* 1e23309 Wait for platform view to appear in iOS UI tests (flutter/engine#19725)

ferhatb deleted the ulps1 branch

August 10, 2020 20:35

Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request


          Roll Engine from f10f172 to 1e23309 (55 revisions) (flutter#61435)

ba7b426

* 160b268 Set locale in Linux shell (flutter/engine#19470)

* c479b93 Fix documentation of unset platform view ID (flutter/engine#19320)

* f3ab78d Fix clipboard paste functionality not working (flutter/engine#19489)

* 9345347 Added the ability to set properties in interface builder for FlutterViewController. (flutter/engine#19458)

* 69fdf6d Use identical in hashValues instead of operator== (flutter/engine#19615)

* 3dc8163 [android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak (flutter/engine#19620)

* b16c47d using text capitalization value in web (flutter/engine#19564)

* 49c0161 Roll Skia from 16bf7d31c819 to 4d48bb35972f (32 revisions) (flutter/engine#19635)

* 2d6afa7 Roll Skia from 4d48bb35972f to 9f821489c9f3 (4 revisions) (flutter/engine#19638)

* 35f59b9 Roll Fuchsia Linux SDK from NC9pp... to 5R9a0... (flutter/engine#19639)

* 53038e2 Roll Fuchsia Mac SDK from iwQCA... to Wym-S... (flutter/engine#19640)

* d9e68f4 Roll Skia from 9f821489c9f3 to f8a6b5b4b0d0 (1 revision) (flutter/engine#19643)

* d329617 Changes to fix build errors in google3. (flutter/engine#19616)

* dd0a6c4 Roll Skia from f8a6b5b4b0d0 to 5160e8caa226 (9 revisions) (flutter/engine#19647)

* d98d539 Manual Roll of Dart dfdc7e45c5...06cb010247 (flutter/engine#19649)

* dfd0727 don't throw error for the new autofill request (flutter/engine#19633)

* 39e98d2 Manual Skia roll to c91db040ad18b9cc3236e342e9acca020eaafd10 (flutter/engine#19650)

* f9acd08 Avoid a copy in EncodeImage (flutter/engine#19504)

* 7e101f1 Roll Fuchsia Linux SDK from 5R9a0... to GOf1K... (flutter/engine#19656)

* f3be9f1 Incorporate compat info changes into flutter engine (flutter/engine#19606)

* 9188ff6 Manual Roll of Dart 707c6404f9...dfdc7e45c5 (flutter/engine#19657)

* cbdd3e2 Roll Fuchsia Mac SDK from Wym-S... to -v4bL... (flutter/engine#19661)

* 6efb152 Roll Dart SDK from 707c6404f969 to 0e25306d3f78 (4 revisions) (flutter/engine#19666)

* 22a440c Roll Dart SDK from 0e25306d3f78 to 6d06476bae6b (1 revision) (flutter/engine#19669)

* 8063923 Roll Fuchsia Linux SDK from GOf1K... to QWI76... (flutter/engine#19671)

* c99deb0 CkPaint uses SkPaint (flutter/engine#19562)

* 015f2ea Use the main bundle if the App bundle is not found (flutter/engine#18749)

* f82d30b Roll Dart SDK from 6d06476bae6b to a9e67d81941a (3 revisions) (flutter/engine#19677)

* 61b2fd2 Roll Fuchsia Mac SDK from -v4bL... to phQJt... (flutter/engine#19681)

* 74b541d Roll Fuchsia Linux SDK from QWI76... to mrlGt... (flutter/engine#19682)

* 25ce3db Roll Skia from c91db040ad18 to e4f36d7ac8f5 (20 revisions) (flutter/engine#19686)

* 162dba1 Roll Skia from e4f36d7ac8f5 to ed15b1c39b8b (1 revision) (flutter/engine#19687)

* f97c38b Roll Fuchsia Mac SDK from phQJt... to kEVc6... (flutter/engine#19688)

* 40c4ee8 Roll Fuchsia Linux SDK from mrlGt... to YfVT0... (flutter/engine#19690)

* ec944b0 Roll Skia from ed15b1c39b8b to 1434ce1aa94d (1 revision) (flutter/engine#19692)

* 7ce988a Roll Skia from 1434ce1aa94d to f64be13cbf84 (2 revisions) (flutter/engine#19695)

* 5f7ca41 Roll Fuchsia Mac SDK from kEVc6... to hRul_... (flutter/engine#19696)

* d24549c Roll Skia from f64be13cbf84 to 041796e60364 (3 revisions) (flutter/engine#19697)

* 617bd88 Roll Dart SDK from a9e67d81941a to fecc8163afc7 (3 revisions) (flutter/engine#19703)

* 8d241e4 [Android] Prevent FlutterRenderer listener from calling JNI after detach (flutter/engine#19558)

* 309e514 Roll Skia from 041796e60364 to d1ce4cb2beb8 (2 revisions) (flutter/engine#19704)

* 211f18e Roll Skia from d1ce4cb2beb8 to 7c1967700b44 (6 revisions) (flutter/engine#19707)

* 0532227 Roll Skia from 7c1967700b44 to 439709a97dfd (8 revisions) (flutter/engine#19712)

* 1e02bfd Support decimal information on the TextInputType (flutter/engine#19664)

* 7a95e32 Linux: Use a hash table to map cursors (flutter/engine#19561)

* df23044 [web] Implement ulps for path ops (flutter/engine#19711)

* 4a3aa4d Fixes typo in android_context_gl.h (flutter/engine#19700)

* 5b966eb Roll Skia from 439709a97dfd to 2604a89d3353 (3 revisions) (flutter/engine#19715)

* d024ae4 [fuchsia] Use memory_requirements_2 extension. (flutter/engine#19678)

* 4392fbf Roll Fuchsia Linux SDK from YfVT0... to 2ct5j... (flutter/engine#19720)

* ab05c79 Roll Fuchsia Mac SDK from hRul_... to ZXLvD... (flutter/engine#19721)

* c05ca7e Roll Dart SDK from fecc8163afc7 to f997d62a6d29 (13 revisions) (flutter/engine#19722)

* ae37971 Remove xcpretty from unit tests to see full output on test failures (flutter/engine#19667)

* 91f80ef Moved to RMSE for image comparison to account for slight variations in golden image tests (flutter/engine#19658)

* 1e23309 Wait for platform view to appear in iOS UI tests (flutter/engine#19725)

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request


          Roll Engine from f10f172 to 1e23309 (55 revisions) (flutter#61435)

441eabd

* 160b268 Set locale in Linux shell (flutter/engine#19470)

* c479b93 Fix documentation of unset platform view ID (flutter/engine#19320)

* f3ab78d Fix clipboard paste functionality not working (flutter/engine#19489)

* 9345347 Added the ability to set properties in interface builder for FlutterViewController. (flutter/engine#19458)

* 69fdf6d Use identical in hashValues instead of operator== (flutter/engine#19615)

* 3dc8163 [android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak (flutter/engine#19620)

* b16c47d using text capitalization value in web (flutter/engine#19564)

* 49c0161 Roll Skia from 16bf7d31c819 to 4d48bb35972f (32 revisions) (flutter/engine#19635)

* 2d6afa7 Roll Skia from 4d48bb35972f to 9f821489c9f3 (4 revisions) (flutter/engine#19638)

* 35f59b9 Roll Fuchsia Linux SDK from NC9pp... to 5R9a0... (flutter/engine#19639)

* 53038e2 Roll Fuchsia Mac SDK from iwQCA... to Wym-S... (flutter/engine#19640)

* d9e68f4 Roll Skia from 9f821489c9f3 to f8a6b5b4b0d0 (1 revision) (flutter/engine#19643)

* d329617 Changes to fix build errors in google3. (flutter/engine#19616)

* dd0a6c4 Roll Skia from f8a6b5b4b0d0 to 5160e8caa226 (9 revisions) (flutter/engine#19647)

* d98d539 Manual Roll of Dart dfdc7e45c5...06cb010247 (flutter/engine#19649)

* dfd0727 don't throw error for the new autofill request (flutter/engine#19633)

* 39e98d2 Manual Skia roll to c91db040ad18b9cc3236e342e9acca020eaafd10 (flutter/engine#19650)

* f9acd08 Avoid a copy in EncodeImage (flutter/engine#19504)

* 7e101f1 Roll Fuchsia Linux SDK from 5R9a0... to GOf1K... (flutter/engine#19656)

* f3be9f1 Incorporate compat info changes into flutter engine (flutter/engine#19606)

* 9188ff6 Manual Roll of Dart 707c6404f9...dfdc7e45c5 (flutter/engine#19657)

* cbdd3e2 Roll Fuchsia Mac SDK from Wym-S... to -v4bL... (flutter/engine#19661)

* 6efb152 Roll Dart SDK from 707c6404f969 to 0e25306d3f78 (4 revisions) (flutter/engine#19666)

* 22a440c Roll Dart SDK from 0e25306d3f78 to 6d06476bae6b (1 revision) (flutter/engine#19669)

* 8063923 Roll Fuchsia Linux SDK from GOf1K... to QWI76... (flutter/engine#19671)

* c99deb0 CkPaint uses SkPaint (flutter/engine#19562)

* 015f2ea Use the main bundle if the App bundle is not found (flutter/engine#18749)

* f82d30b Roll Dart SDK from 6d06476bae6b to a9e67d81941a (3 revisions) (flutter/engine#19677)

* 61b2fd2 Roll Fuchsia Mac SDK from -v4bL... to phQJt... (flutter/engine#19681)

* 74b541d Roll Fuchsia Linux SDK from QWI76... to mrlGt... (flutter/engine#19682)

* 25ce3db Roll Skia from c91db040ad18 to e4f36d7ac8f5 (20 revisions) (flutter/engine#19686)

* 162dba1 Roll Skia from e4f36d7ac8f5 to ed15b1c39b8b (1 revision) (flutter/engine#19687)

* f97c38b Roll Fuchsia Mac SDK from phQJt... to kEVc6... (flutter/engine#19688)

* 40c4ee8 Roll Fuchsia Linux SDK from mrlGt... to YfVT0... (flutter/engine#19690)

* ec944b0 Roll Skia from ed15b1c39b8b to 1434ce1aa94d (1 revision) (flutter/engine#19692)

* 7ce988a Roll Skia from 1434ce1aa94d to f64be13cbf84 (2 revisions) (flutter/engine#19695)

* 5f7ca41 Roll Fuchsia Mac SDK from kEVc6... to hRul_... (flutter/engine#19696)

* d24549c Roll Skia from f64be13cbf84 to 041796e60364 (3 revisions) (flutter/engine#19697)

* 617bd88 Roll Dart SDK from a9e67d81941a to fecc8163afc7 (3 revisions) (flutter/engine#19703)

* 8d241e4 [Android] Prevent FlutterRenderer listener from calling JNI after detach (flutter/engine#19558)

* 309e514 Roll Skia from 041796e60364 to d1ce4cb2beb8 (2 revisions) (flutter/engine#19704)

* 211f18e Roll Skia from d1ce4cb2beb8 to 7c1967700b44 (6 revisions) (flutter/engine#19707)

* 0532227 Roll Skia from 7c1967700b44 to 439709a97dfd (8 revisions) (flutter/engine#19712)

* 1e02bfd Support decimal information on the TextInputType (flutter/engine#19664)

* 7a95e32 Linux: Use a hash table to map cursors (flutter/engine#19561)

* df23044 [web] Implement ulps for path ops (flutter/engine#19711)

* 4a3aa4d Fixes typo in android_context_gl.h (flutter/engine#19700)

* 5b966eb Roll Skia from 439709a97dfd to 2604a89d3353 (3 revisions) (flutter/engine#19715)

* d024ae4 [fuchsia] Use memory_requirements_2 extension. (flutter/engine#19678)

* 4392fbf Roll Fuchsia Linux SDK from YfVT0... to 2ct5j... (flutter/engine#19720)

* ab05c79 Roll Fuchsia Mac SDK from hRul_... to ZXLvD... (flutter/engine#19721)

* c05ca7e Roll Dart SDK from fecc8163afc7 to f997d62a6d29 (13 revisions) (flutter/engine#19722)

* ae37971 Remove xcpretty from unit tests to see full output on test failures (flutter/engine#19667)

* 91f80ef Moved to RMSE for image comparison to account for slight variations in golden image tests (flutter/engine#19658)

* 1e23309 Wait for platform view to appear in iOS UI tests (flutter/engine#19725)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels