Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin_registrar_windows.h to published wrapper #15265

Conversation

stuartmorgan
Copy link
Contributor

This file was missed in the wrapper publishing during the switch to the
Win32 embedding, so it's not part of the wrapper package that is
available to clients. This adds it to the published wrapper, as
originally intended.

This file was missed in the wrapper publishing during the switch to the
Win32 embedding, so it's not part of the wrapper package that is
available to clients. This adds it to the published wrapper, as
originally intended.
@stuartmorgan stuartmorgan added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 8, 2020
@fluttergithubbot fluttergithubbot merged commit a39f3f0 into flutter:master Jan 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 8, 2020
flutter/engine@a50f1ef...4e9e69d

git log a50f1ef..4e9e69d --first-parent --oneline
2020-01-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from nbeLe... to gL-XG... (flutter/engine#15253)
2020-01-08 stuartmorgan@google.com Add plugin_registrar_windows.h to published wrapper (flutter/engine#15265)
2020-01-08 skia-flutter-autoroll@skia.org Roll src/third_party/dart bebc7d3af5bd..c0ca187f2699 (37 commits) (flutter/engine#15252)
2020-01-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from xYmDF... to oNKzr... (flutter/engine#15257)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
bkonyi pushed a commit to flutter/flutter that referenced this pull request Jan 9, 2020
flutter/engine@a50f1ef...4e9e69d

git log a50f1ef..4e9e69d --first-parent --oneline
2020-01-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from nbeLe... to gL-XG... (flutter/engine#15253)
2020-01-08 stuartmorgan@google.com Add plugin_registrar_windows.h to published wrapper (flutter/engine#15265)
2020-01-08 skia-flutter-autoroll@skia.org Roll src/third_party/dart bebc7d3af5bd..c0ca187f2699 (37 commits) (flutter/engine#15252)
2020-01-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from xYmDF... to oNKzr... (flutter/engine#15257)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants