Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BitmapCanvas, lazily allocate canvas, fix image composition bug. #15153

Merged
merged 9 commits into from
Jan 7, 2020
Merged

Refactor BitmapCanvas, lazily allocate canvas, fix image composition bug. #15153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8b30bfd
Refactor BitmapCanvas. Fix image compositing bug. Allocate canvas lazily
ferhatb Jan 6, 2020
c6c58fa
dartfmt
ferhatb Jan 6, 2020
703d703
Address review comments
ferhatb Jan 6, 2020
98fbb63
update licenses_flutter for new canvas_pool.dart
ferhatb Jan 6, 2020
9ab3c29
Merge remote-tracking branch 'upstream/master' into draw_on_image6
ferhatb Jan 7, 2020
12f0c20
Update golden lock
ferhatb Jan 7, 2020
540ad19
Fix recording canvas test by restoring context save
ferhatb Jan 7, 2020
e11799e
Update recording canvas test for drawColor to show multiply blend
ferhatb Jan 7, 2020
5a617bf
Fix missing rc.restore calls in test
ferhatb Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/licenses_golden/licenses_flutter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,7 @@ FILE: ../../../flutter/lib/web_ui/lib/src/engine/assets.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/bitmap_canvas.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/browser_detection.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/browser_location.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/canvas_pool.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/color_filter.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/compositor/canvas.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/compositor/canvas_kit_canvas.dart
Expand Down
2 changes: 1 addition & 1 deletion lib/web_ui/dev/goldens_lock.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
repository: https://github.com/flutter/goldens.git
revision: a121ff1169a1b478274a3e34c95d0a1d2d685948
revision: c0032eeb9f9f064234991b8b5ddc15f714a53cf5
1 change: 1 addition & 0 deletions lib/web_ui/lib/src/engine.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ part 'engine/assets.dart';
part 'engine/bitmap_canvas.dart';
part 'engine/browser_detection.dart';
part 'engine/browser_location.dart';
part 'engine/canvas_pool.dart';
part 'engine/color_filter.dart';
part 'engine/compositor/canvas.dart';
part 'engine/compositor/canvas_kit_canvas.dart';
Expand Down
Loading