Skip to content

Commit

Permalink
[web] fix clicks on merged semantic nodes (attempt #2) (#47360)
Browse files Browse the repository at this point in the history 
This relands #43620 with a fix for nested tappable nodes. The first PR introduced this regression: flutter/flutter#134842.

This PR includes the original PR and a fix for the regression. The fix is to call `stopPropagation` on the "click" event so that it is not handled by the ancestor if the child has already decided to send a `SemanticsAction.tap` to the framework. This ensures that there cannot be more than one `SemanticsAction.tap` sent to the framework.

Fixes flutter/flutter#134842
  • Loading branch information
@yjbanov
yjbanov authored Nov 8, 2023
1 parent bd15e8f commit eb3b2bb
Show file tree
Hide file tree
Showing 7 changed files with 844 additions and 124 deletions.
Loading

0 comments on commit eb3b2bb

Please sign in to comment.