Feedback

flutter · Dec 13, 2023 · 4bea4a5 · 4bea4a5
1 parent 5d84204
commit 4bea4a5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/shell/platform/windows/compositor_opengl.cc b/shell/platform/windows/compositor_opengl.cc
@@ -78,6 +78,8 @@ bool CompositorOpenGL::CollectBackingStore(const FlutterBackingStore* store) {
 
 bool CompositorOpenGL::Present(const FlutterLayer** layers,
                                size_t layers_count) {
+  // TODO: Support compositing layers and platform views.
+  // See: https://github.com/flutter/flutter/issues/31713
   FML_DCHECK(is_initialized_);
   FML_DCHECK(layers_count == 1);
   FML_DCHECK(layers[0]->type == kFlutterLayerContentTypeBackingStore);

diff --git a/shell/platform/windows/compositor_opengl_unittests.cc b/shell/platform/windows/compositor_opengl_unittests.cc
@@ -96,7 +96,7 @@ class CompositorOpenGLTest : public WindowsTest {
 
     engine_ = builder.Build();
     EngineModifier modifier(engine_.get());
-    modifier.SetSurfaceManager(surface_manager.release());
+    modifier.SetSurfaceManager(std::move(surface_manager));
   }
 
   void UseEngineWithView() {

diff --git a/shell/platform/windows/compositor_software.cc b/shell/platform/windows/compositor_software.cc
@@ -39,6 +39,8 @@ bool CompositorSoftware::CollectBackingStore(const FlutterBackingStore* store) {
 
 bool CompositorSoftware::Present(const FlutterLayer** layers,
                                  size_t layers_count) {
+  // TODO: Support compositing layers and platform views.
+  // See: https://github.com/flutter/flutter/issues/31713
   FML_DCHECK(layers_count == 1);
   FML_DCHECK(layers[0]->type == kFlutterLayerContentTypeBackingStore);
   FML_DCHECK(layers[0]->backing_store->type ==